Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
  • Repository
  • Issues 803
  • Merge Requests 52
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !608

Merged
Opened 2 weeks ago by Emiliano Balbuena@edgebal31 of 31 tasks completed31/31 tasks
Report abuse

Product pages update

  • Plus page contents
  • Pro page contents
  • Nodes page contents
  • Upgrades page contents update
  • Pay page contents
  • Rewards page contents
  • Token page contents
  • Boost page contents
  • Footer layout and style update (desktop and mobile, light and dark)
  • Style 3 foundations (desktop and mobile, light and dark)
  • Style 4 foundations (desktop and mobile, light and dark)
  • Style Tail foundations (desktop and mobile, light and dark)
  • Plus page assets
  • Pro page assets
  • Nodes page assets
  • Pay page assets
  • Rewards page assets
  • Token page assets
  • Boost page assets
  • Style 3 decoration
  • Style 4 decoration
  • Style tail separators
  • Nodes page actions
  • Pay page actions
  • Rewards page actions
  • Boost page actions
  • Rewards page dynamic values
  • Buy token component
  • E2E Tests for product pages
  • Review footer link destinations
  • Final Boost page content (follow up #2037 (closed))

Issues

  • Closes #2037 (closed)
  • Closes #2108 (closed)
  • Closes #2141 (closed)
  • Closes #2142 (closed)
  • Closes #2200 (closed)
Edited 13 hours ago by Emiliano Balbuena
Request to merge goal/product-pages-update-1 into master
Pipeline #93608543 passed with warnings for 95efda66 on goal/product-pages-update-1
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              All merge request dependencies have been merged (1 merged)

              Merged by Mark Harding 13 minutes ago

              The changes were merged into master with e22df34a

              The source branch has been deleted

              Closed #2037 (closed), #2108 (closed), #2141 (closed), #2142 (closed), and #2200 (closed)

              Pipeline #93720329 running for e22df34a on master
                            • Discussion 1
                            • Commits 37
                            • Pipelines 28
                            • Changes 133
                            0/1 thread resolved
                            • Emiliano Balbuena @edgebal changed milestone to %Pro Beta #release 2 weeks ago

                              changed milestone to %Pro Beta #release

                            • Emiliano Balbuena @edgebal added Squad::Yellow scoped label 2 weeks ago

                              added scoped label

                            • Emiliano Balbuena @edgebal changed the description 2 times within 4 minutes 2 weeks ago

                              changed the description 2 times within 4 minutes

                            • Emiliano Balbuena @edgebal added 2 commits 2 weeks ago

                              added 2 commits

                              • 1c40fdda - (chore): never call the legacy categories modal - 2124
                              • 41534fed - App changes to support Angular Hot Module Reloading for dev env

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

                              added 1 commit

                              • 9142411a - (chore): Blockchain marketing pages content

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 4 commits 2 weeks ago

                              added 4 commits

                              • 9142411a...66944378 - 3 commits from branch master
                              • 70df5d64 - Merge remote-tracking branch 'origin/master' into goal/product-pages-update-1

                              Compare with previous version

                            • Emiliano Balbuena @edgebal marked the task Pay page contents as completed 2 weeks ago

                              marked the task Pay page contents as completed

                            • Emiliano Balbuena @edgebal marked the task Rewards page contents as completed 2 weeks ago

                              marked the task Rewards page contents as completed

                            • Emiliano Balbuena @edgebal marked the task Token page contents as completed 2 weeks ago

                              marked the task Token page contents as completed

                            • Emiliano Balbuena @edgebal added 6h of time spent at 2019-10-21 2 weeks ago

                              added 6h of time spent at 2019-10-21

                            • Emiliano Balbuena @edgebal removed time spent 2 weeks ago

                              removed time spent

                            • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

                              added 1 commit

                              • 95918ed3 - (wip): Styles split/style 3

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

                              added 1 commit

                              • f106ce12 - (feat): Style 3; style 4; style tail

                              Compare with previous version

                            • Emiliano Balbuena @edgebal changed the description 2 weeks ago

                              changed the description

                            • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                              added 1 commit

                              • 430074c4 - (feat): Token, Plus, Pro, Nodes imagery

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                              added 1 commit

                              • 03673a03 - (feat): Pay and Rewards imagery

                              Compare with previous version

                            • Emiliano Balbuena @edgebal changed the description 1 week ago

                              changed the description

                            • Emiliano Balbuena @edgebal added 2 commits 1 week ago

                              added 2 commits

                              • 231a45ac - (feat): Style tail decoration
                              • acc30fa5 - (fix): Marketing point value emphasis

                              Compare with previous version

                            • Emiliano Balbuena @edgebal marked the task Style 3 decoration as completed 1 week ago

                              marked the task Style 3 decoration as completed

                            • Emiliano Balbuena @edgebal marked the task Style 4 decoration as completed 1 week ago

                              marked the task Style 4 decoration as completed

                            • Emiliano Balbuena @edgebal marked the task Style tail separators as completed 1 week ago

                              marked the task Style tail separators as completed

                            • Emiliano Balbuena @edgebal marked the task Boost page contents as completed 1 week ago

                              marked the task Boost page contents as completed

                            • Emiliano Balbuena @edgebal marked the task Boost page assets as completed 1 week ago

                              marked the task Boost page assets as completed

                            • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                              added 1 commit

                              • e787b240 - (feat): Boost page contents and imagery

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                              added 1 commit

                              • 6b5ad0bc - (feat): Style 2 and 3 decoration artifacts

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 3 commits 1 week ago

                              added 3 commits

                              • 6b5ad0bc...5e3c86ef - 2 commits from branch master
                              • d2649b1e - Merge remote-tracking branch 'origin/master' into goal/product-pages-update-1

                              Compare with previous version

                            • Emiliano Balbuena @edgebal changed the description 1 week ago

                              changed the description

                            • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                              added 1 commit

                              • c57609f8 - (fix): Correct shadows in UX sample images on product pages

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 2 commits 1 week ago

                              added 2 commits

                              • 3bfdb21a - (fix): Fix inter-section spacing
                              • 6e09929c - (feat): Use dynamic values when showing contribution on product page

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                              added 1 commit

                              • aeab3d4b - (feat): Product pages button actions

                              Compare with previous version

                            • Emiliano Balbuena @edgebal marked the task Nodes page actions as completed 1 week ago

                              marked the task Nodes page actions as completed

                            • Emiliano Balbuena @edgebal marked the task Pay page actions as completed 1 week ago

                              marked the task Pay page actions as completed

                            • Emiliano Balbuena @edgebal marked the task Rewards page actions as completed 1 week ago

                              marked the task Rewards page actions as completed

                            • Emiliano Balbuena @edgebal marked the task Boost page actions as completed 1 week ago

                              marked the task Boost page actions as completed

                            • Emiliano Balbuena @edgebal marked the task Rewards page dynamic values as completed 1 week ago

                              marked the task Rewards page dynamic values as completed

                            • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                              added 1 commit

                              • 49345cb7 - (chore): Analytics SEO banner

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 5 commits 1 week ago

                              added 5 commits

                              • 49345cb7...d66805df - 4 commits from branch master
                              • 7e932b8b - Merge remote-tracking branch 'origin/master' into goal/product-pages-update-1

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                              added 1 commit

                              • 46094e5c - (feat): Re-introduce the ability to buy tokens

                              Compare with previous version

                            • Emiliano Balbuena @edgebal marked the task Buy token component as completed 1 week ago

                              marked the task Buy token component as completed

                            • Marcelo Rivera @eiennohi mentioned in merge request !623 5 days ago

                              mentioned in merge request !623

                            • Emiliano Balbuena @edgebal added 3 commits 4 days ago

                              added 3 commits

                              • 46094e5c...80069206 - 2 commits from branch master
                              • 4fe4cdd1 - Merge remote-tracking branch 'origin/master' into goal/product-pages-update-1

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 3 days ago

                              added 1 commit

                              • 20fb225c - (test): E2E for /upgrades

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 3 days ago

                              added 1 commit

                              • 17b77c45 - (tests): E2E for simple product pages

                              Compare with previous version

                            • Emiliano Balbuena @edgebal changed the description 3 days ago

                              changed the description

                            • Ben Hayward
                              Ben Hayward @benhayward.ben started a thread on an old version of the diff 3 days ago
                              Last updated by Emiliano Balbuena 1 day ago
                              cypress/integration/upgrades.spec.js
                              55 cy.get(anyBuyTokensModal).should('be.visible');
                              56 });
                              57
                              58 it('should have the ability to trigger Buy Eth modal', () => {
                              59 const buyEthLink =
                              60 'm-blockchain--purchase .m-blockchainTokenPurchase__ethRate a';
                              61 const buyEthModal = 'm-blockchain__eth-modal .m-modal-container';
                              62
                              63 cy.get(buyEthLink).click();
                              64
                              65 cy.get(buyEthModal).should('be.visible');
                              66 });
                              67
                              68 it('should navigate to Plus and trigger a Wire', () => {
                              69 const upgradeButton = cy.get(
                              70 '.mf-button.m-upgradesUpgradeOptionsPlan__action:eq(0)'
                              • Ben Hayward
                                Ben Hayward @benhayward.ben · 3 days ago
                                Developer

                                Might be best to change this and the other selectors used here, to a contains or a data-attribute. Unsure what its actually referencing so may be an exception to the rule but indexed selection is our enemy, as it'll break more easily.

                              • Emiliano Balbuena @edgebal changed this line in version 22 of the diff 1 day ago

                                changed this line in version 22 of the diff

                              • Please register or sign in to reply
                            • Emiliano Balbuena @edgebal added 1 commit 1 day ago

                              added 1 commit

                              • b77e02c6 - (test): Use data-cy to select upgrade buttons

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 28 commits 17 hours ago

                              added 28 commits

                              • b77e02c6...e56f318f - 27 commits from branch master
                              • 270fe964 - Merge remote-tracking branch 'origin/master' into goal/product-pages-update-1

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 15 hours ago

                              added 1 commit

                              • 74276743 - (chore): Update product pages copy; new links style

                              Compare with previous version

                            • Emiliano Balbuena @edgebal marked the task Final Boost page content (follow up #2037 (closed)) as completed 15 hours ago

                              marked the task Final Boost page content (follow up ) as completed

                            • Emiliano Balbuena @edgebal changed the description 15 hours ago

                              changed the description

                            • Emiliano Balbuena @edgebal marked the task Review footer link destinations as completed 14 hours ago

                              marked the task Review footer link destinations as completed

                            • Emiliano Balbuena @edgebal added 4 commits 14 hours ago

                              added 4 commits

                              • c043dcfe - (chore): /nodes typo
                              • 25ec0b48 - (chore): Resize /upgrades columns
                              • a750deb2 - (chore): New imagery for product pages
                              • 946a907d - (chore): UX samples for product pages

                              Compare with previous version

                              Toggle commit list
                            • Emiliano Balbuena @edgebal added 2 commits 13 hours ago

                              added 2 commits

                              • cac9e7dc - (chore): Update "As featured in"
                              • 8669b85d - (chore): Center style 3 and 4 bodies

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 13 hours ago

                              added 1 commit

                              • 95efda66 - (chore): Update footer

                              Compare with previous version

                            • Emiliano Balbuena @edgebal unmarked as a Work In Progress 13 hours ago

                              unmarked as a Work In Progress

                            • Mark Harding @markeharding approved this merge request 15 minutes ago

                              approved this merge request

                            • Mark Harding @markeharding mentioned in commit e22df34a 13 minutes ago

                              mentioned in commit e22df34a

                            • Mark Harding @markeharding merged 13 minutes ago

                              merged

                            Please register or sign in to reply
                            Assignee
                            Emiliano Balbuena's avatar
                            Emiliano Balbuena @edgebal
                            Pro Beta #release
                            Milestone
                            Pro Beta #release
                            Time tracking
                            No estimate or time spent
                            1
                            Labels
                            Squad::Yellow
                            Lock merge request
                            Unlocked
                            10
                            10 participants
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Ben Hayward
                            user avatar
                            Martin Santangelo
                            user avatar
                            Olivia Madrid
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Guy Thouret
                            user avatar
                            Brian Hatchet
                            Reference: minds/front!608