Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
  • Repository
  • Issues 805
  • Merge Requests 52
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !620

Open
Opened 1 week ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/QuietQuail](fix): Adjusted padded element to prevent misclicks. #2114

Testing

Try click around the edges of the dropdown

image

Request to merge fix/dropdown-padding-2114 into master
The source branch is 27 commits behind the target branch
Open in Web IDE
Pipeline #93468227 passed with warnings for 032c314c on fix/dropdown-padding-2114
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena
              Emiliano Balbuena
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Mentions #2114

              Deletes source branch

              • Discussion 2
              • Commits 3
              • Pipelines 3
              • Changes 2
              0/2 threads resolved
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 week ago

                added scoped labels

              • Ben Hayward @benhayward.ben added 1 commit 6 days ago

                added 1 commit

                • a4c3da15 - Fixed light option

                Compare with previous version

              • Ben Hayward @benhayward.ben mentioned in issue #2138 (closed) 21 hours ago

                mentioned in issue #2138 (closed)

              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 9 hours ago
                src/app/common/components/dropdown/dropdown.component.scss
                94 95
                95 96 .m-dropdown--list--item,
                96 97 .m-dropdownList__item {
                97 padding: 8px;
                98 98 @include m-theme() {
                99 99 border-bottom: 1px solid themed($m-grey-50);
                100 100 }
                101 101
                102 a,
                • Mark Harding
                  Mark Harding @markeharding · 9 hours ago
                  Owner

                  perhaps just use > * incase it is not either a a or div (could be span etc).

                • Please register or sign in to reply
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 9 hours ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added 1 commit 6 hours ago

                added 1 commit

                • 032c314c - Updated to catch future additions

                Compare with previous version

              • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 6 hours ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben resolved all threads 6 hours ago

                resolved all threads

              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 59 minutes ago
                src/app/common/components/dropdown/dropdown.component.scss
                94 94
                95 95 .m-dropdown--list--item,
                96 96 .m-dropdownList__item {
                97 padding: 8px;
                98 97 @include m-theme() {
                99 98 border-bottom: 1px solid themed($m-grey-50);
                100 99 }
                101 100
                101 a,
                • Mark Harding
                  Mark Harding @markeharding · 59 minutes ago
                  Owner

                  @benhayward.ben still missing this one

                • Please register or sign in to reply
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 59 minutes ago

                added scoped label and automatically removed label

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Requires Changes Squad::Yellow
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Emiliano Balbuena
              user avatar
              Martin Santangelo
              user avatar
              Juan Manuel Solaro
              user avatar
              Guy Thouret
              user avatar
              Mark Harding
              user avatar
              Olivia Madrid
              user avatar
              Marcelo Rivera
              Reference: minds/front!620