Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
  • Repository
  • Issues 805
  • Merge Requests 52
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !616

Open
Opened 1 week ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/QuietQuail](fix): Ensure already set NSFW values are taken into account when posting #2161

Closes #2161

The issue

On production, if you make an NSFW post, then go to another page, like wallet, and go back to the feed, the nsfw selector will still be lit up blue, but if you post, the post does not have the NSFW tags.

Testing

  1. Make an NSFW post
  2. Click wallets, then back to newsfeed, see the selector is still blue but don't click on it (as that behaviour does not cause the bug on prod).
  3. Type something, post - it should be NSFW
  4. Post an image - it should be NSFW
  5. Turn off NSFW selectors
  6. Try and image and text to make sure that they are not set as NSFW.
Request to merge fix/nsfw-toggle-2161 into master
The source branch is 29 commits behind the target branch
Open in Web IDE
Pipeline #91379713 passed with warnings for 7ab7c4a2 on fix/nsfw-toggle-2161
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2161

              Deletes source branch

              • Discussion 1
              • Commits 2
              • Pipelines 2
              • Changes 1
              • Ben Hayward @benhayward.ben added 1 commit 1 week ago

                added 1 commit

                • 7ab7c4a2 - Update nsfw-selector.component.ts

                Compare with previous version

              • Mark Harding @markeharding approved this merge request 30 minutes ago

                approved this merge request

              • Mark Harding @markeharding added MR::Ready to Merge scoped label 30 minutes ago

                added scoped label

              • Mark Harding
                Mark Harding @markeharding · 30 minutes ago
                Owner

                @xander-miller feel free to merge if you are happy this works

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              1
              Labels
              MR::Ready to Merge
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Emiliano Balbuena
              user avatar
              Martin Santangelo
              user avatar
              Juan Manuel Solaro
              user avatar
              Guy Thouret
              user avatar
              Olivia Madrid
              user avatar
              Marcelo Rivera
              user avatar
              Brian Hatchet
              Reference: minds/front!616