Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
  • Repository
  • Issues 804
  • Merge Requests 51
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !575

Merged
Opened 1 month ago by Marcelo Rivera@eiennohi
Report abuse

(feat): footer items should open in new tab if they link to outside domains

closes #1944 (closed)

Edited 3 weeks ago by Marcelo Rivera
Request to merge feat/footer-links-1944 into master
Pipeline #93490859 failed for 64fe2382 on feat/footer-links-1944
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller

              Merged by Mark Harding 1 hour ago

              The changes were merged into master with 409ccf04

              The source branch has been deleted

              Closed #1944 (closed)

              Pipeline #93497962 waiting for manual action for 409ccf04 on master
                            • Discussion 2
                            • Commits 4
                            • Pipelines 3
                            • Changes 3
                            • Marcelo Rivera @eiennohi changed milestone to %Minds Pro #rollout 1 month ago

                              changed milestone to %Minds Pro #rollout

                            • Marcelo Rivera @eiennohi added Product::Pro Sprint::09/25 - Oldfashioned Owl Squad::Yellow scoped labels 1 month ago

                              added scoped labels

                            • Emiliano Balbuena @edgebal marked as a Work In Progress 1 month ago

                              marked as a Work In Progress

                            • Marcelo Rivera @eiennohi added 20 commits 3 weeks ago

                              added 20 commits

                              • 1cd44d14...534f449e - 18 commits from branch master
                              • dce51e85 - Merge remote-tracking branch 'upstream/master' into feat/footer-links-1944
                              • 63cc9056 - (fix): should open links from the same domain in the same tab

                              Compare with previous version

                            • Marcelo Rivera @eiennohi unmarked as a Work In Progress 3 weeks ago

                              unmarked as a Work In Progress

                            • Mark Harding @markeharding approved this merge request 3 hours ago

                              approved this merge request

                            • Mark Harding @markeharding added MR::Requires Changes scoped label 3 hours ago

                              added scoped label

                            • Mark Harding @markeharding unapproved this merge request 3 hours ago

                              unapproved this merge request

                            • Mark Harding
                              Mark Harding @markeharding · 3 hours ago
                              Owner

                              @eiennohi can you fix the merge conflicts here?

                            • Marcelo Rivera @eiennohi added 87 commits 2 hours ago

                              added 87 commits

                              • 63cc9056...5f0eb8ea - 86 commits from branch master
                              • 64fe2382 - Merge remote-tracking branch 'upstream/master' into feat/footer-links-1944

                              Compare with previous version

                            • Marcelo Rivera
                              Marcelo Rivera @eiennohi · 2 hours ago
                              Developer

                              @markeharding just updated

                            • Mark Harding @markeharding approved this merge request 1 hour ago

                              approved this merge request

                            • Mark Harding @markeharding merged 1 hour ago

                              merged

                            • Mark Harding @markeharding mentioned in commit 409ccf04 1 hour ago

                              mentioned in commit 409ccf04

                            Please register or sign in to reply
                            0 Assignees
                            None
                            Pro soft launch
                            Milestone
                            Pro soft launch
                            Time tracking
                            No estimate or time spent
                            4
                            Labels
                            MR::Requires Changes Product::Pro Sprint::09/25 - Oldfashioned Owl Squad::Yellow
                            Lock merge request
                            Unlocked
                            10
                            10 participants
                            user avatar
                            Emiliano Balbuena
                            user avatar
                            Martin Santangelo
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Guy Thouret
                            user avatar
                            Olivia Madrid
                            user avatar
                            Brian Hatchet
                            user avatar
                            Ben Hayward
                            Reference: minds/front!575