(fix): don't do anything if the entity isn't an image or video
closes #925 (closed)
Request to merge
fix/sentry-issue-925
into
master
0/1
thread resolved
changed milestone to %Misc. Q4 2019
added scoped labels
added scoped label
![Mark Harding](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
OwnerLinting issues @eiennohi
- Last updated by Marcelo Rivera
36 36 return Factory::response(['status' => 'error']); 37 37 } 38 38 39 if (!in_array(['object:video', 'object:image'], $entity->type)) { - Owner
type will always be object?
changed this line in version 2 of the diff
![Marcelo Rivera](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="80" height="80"><rect fill-opacity="0"/></svg>)
DeveloperJust fixed this line. I think the issue came from someone going into /media/:guid, with an activity guid instead of an image or video. That's why I'm doing the check
added 1 commit
- e3bac422 - (fix): don't do anything if the entity isn't an image or video
- Developer
@markeharding, I just updated
approved this merge request
mentioned in commit bfac17ad
merged
