Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
  • Repository
  • Issues 293
  • Merge Requests 40
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !359

Merged
Opened 3 weeks ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/PinkPanther](fix): Stripping out blog body upon export.

Closes #1916

Summary

Blog paywalls are broken, it shows the text when you access the page, even if it should be behind a paywall

Solution

$this->_eventsDispatcher->trigger('export:extender', 'blog', [ 'entity' => $this ], []) is not being triggered as was intended, it appears that it is not registered correctly at, as the EventDispatcher never sees it. https://gitlab.com/minds/engine/blob/master/Core/Wire/Paywall/Events.php#L70 is not used by any other classes, so the solution I believe is to move the code into the blog namespace.

From left to right

  • 1 - Owner account.
  • 2 - Not logged in.
  • 3 - Other account.

image

To test

  1. Make a blog, put it behind a paywall
  2. Check you can view the content on the owner account.
  3. Check that you cannot access the content when logged out.
  4. Check that you cannot access the content when on a secondary account that has not wired tokens previously to your primary.
  5. Pay for the blog on that account, and verify you can access it (if you need some, drop me a message).
Edited 2 weeks ago by Ben Hayward
Request to merge fix/blog-paywall-1916 into master
Pipeline #88029314 passed with warnings for 245e12cc on fix/blog-paywall-1916
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Emiliano Balbuena
          Emiliano Balbuena
          Martin Santangelo
          Martin Santangelo
          Guy Thouret
          Guy Thouret
          Olivia Madrid
          Olivia Madrid
          Marcelo Rivera
          Marcelo Rivera

          Merged by Mark Harding 40 minutes ago

          The changes were merged into master with 98471672

          The source branch has been deleted

          Pipeline #93461322 waiting for manual action for 98471672 on master
                        • Discussion 1
                        • Commits 2
                        • Pipelines 3
                        • Changes 2
                        • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 3 weeks ago

                          added scoped labels

                        • Ben Hayward @benhayward.ben marked as a Work In Progress 3 weeks ago

                          marked as a Work In Progress

                        • Ben Hayward @benhayward.ben changed the description 3 weeks ago

                          changed the description

                        • Ben Hayward @benhayward.ben added 9 commits 3 weeks ago

                          added 9 commits

                          • 4167bc16...142d395f - 8 commits from branch master
                          • deaf18e5 - Register event in the correct namespace. #1916

                          Compare with previous version

                        • Ben Hayward @benhayward.ben added 1 commit 3 weeks ago

                          added 1 commit

                          • 245e12cc - Removed old handler

                          Compare with previous version

                        • Ben Hayward @benhayward.ben changed the description 3 weeks ago

                          changed the description

                        • Xander Miller
                          Xander Miller @xander-miller · 3 weeks ago
                          Developer

                          When this bug is resolved @javanick Should follow up with minds::@cellblock07208 and minds::@medworthy to thank them and tell them it's fixed.

                        • Ben Hayward @benhayward.ben unmarked as a Work In Progress 2 weeks ago

                          unmarked as a Work In Progress

                        • Ben Hayward @benhayward.ben mentioned in issue front#1916 2 weeks ago

                          mentioned in issue front#1916

                        • Mark Harding @markeharding approved this merge request 40 minutes ago

                          approved this merge request

                        • Mark Harding @markeharding merged 40 minutes ago

                          merged

                        • Mark Harding @markeharding mentioned in commit 98471672 40 minutes ago

                          mentioned in commit 98471672

                        Please register or sign in to reply
                        0 Assignees
                        None
                        None
                        Milestone
                        None
                        Time tracking
                        No estimate or time spent
                        2
                        Labels
                        MR::Awaiting Review Squad::Yellow
                        Lock merge request
                        Unlocked
                        12
                        12 participants
                        user avatar
                        Emiliano Balbuena
                        user avatar
                        Martin Santangelo
                        user avatar
                        Guy Thouret
                        user avatar
                        Olivia Madrid
                        user avatar
                        Marcelo Rivera
                        user avatar
                        Brian Hatchet
                        user avatar
                        Rami Albatal
                        Reference: minds/engine!359