Commit f697713e authored by Emiliano Balbuena's avatar Emiliano Balbuena

(fix): PHP strict errors; (chore): Feeds\Activity routes

1 merge request!342WIP: (feat): Modernize Router (&75)
Pipeline #93457540 passed with stages
in 10 minutes and 31 seconds
......@@ -6,14 +6,21 @@
namespace Minds\Core\Feeds\Activity;
use Zend\Diactoros\ServerRequest;
class Manager
{
public function add()
public function add(ServerRequest $request)
{
throw new \NotImplementedException();
}
public function update(ServerRequest $request)
{
throw new \NotImplementedException();
}
public function update()
public function delete(ServerRequest $request)
{
throw new \NotImplementedException();
}
......
......@@ -12,6 +12,10 @@ class FeedsProvider extends Provider
return new Top\Manager();
});
$this->di->bind('Feeds\Activity\Manager', function ($di) {
return new Activity\Manager();
});
$this->di->bind('Feeds\Firehose\Manager', function ($di) {
return new Firehose\Manager();
});
......
......@@ -6,7 +6,10 @@
namespace Minds\Core\Feeds;
use Minds\Core\Di\Ref;
use Minds\Core\Router\Middleware\LoggedInMiddleware;
use Minds\Core\Router\ModuleRoutes;
use Minds\Core\Router\Route;
class Routes extends ModuleRoutes
{
......@@ -15,5 +18,26 @@ class Routes extends ModuleRoutes
*/
public function register(): void
{
$this->route
->withPrefix('api/v3/newsfeed')
->using([
LoggedInMiddleware::class,
])
->do(function (Route $route) {
$route->post(
'',
Ref::_('Feeds\Activity\Manager', 'add')
);
$route->post(
':guid',
Ref::_('Feeds\Activity\Manager', 'update')
);
$route->delete(
':guid',
Ref::_('Feeds\Activity\Manager', 'delete')
);
});
}
}
......@@ -45,7 +45,7 @@ class ErrorHandlerMiddleware implements MiddlewareInterface
} catch (Exception $e) {
// TODO: Handle Sentry
error_log($e);
error_log((string) $e);
// TODO: Nicer logging
}
......
......@@ -90,7 +90,7 @@ class RegistryEntry
public function matches(string $route): bool
{
$pattern = sprintf("#^%s$#i", strtr(preg_quote($this->getWildcardRoute(), '#'), ['\*' => '[^/]+']));
return preg_match($pattern, $route);
return (bool) preg_match($pattern, $route);
}
/**
......
Please register or to comment