Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
  • Repository
  • Issues 810
  • Merge Requests 54
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !587

Merged
Opened 3 weeks ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/PinkPanther](fix): Upload cancelling #2083

Closes #2083 (closed) Credits to Mark for the elegant solution

Summary

Upload cancellation is broken on production. Go upload a video on it and try to cancel it.

Test

  1. Upload a video, & whilst uploading, upload a second video - it should replace the existing upload, progress bar should not jump erratically.
  2. Try cancelling the upload. it should cancel. - Without a refresh, try to upload a second video.
  3. Uploading a video should complete all the way and post.
  4. Should not interfere with image upload.
Edited 3 weeks ago by Ben Hayward
Request to merge fix/upload-cancel-2083 into master
Pipeline #89838924 passed for 870a33b9 on fix/upload-cancel-2083
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller

              Merged by Mark Harding 13 minutes ago

              The changes were merged into master with 5f0eb8ea

              The source branch has been deleted

              Closed #2083 (closed)

              Pipeline #93457946 running for 5f0eb8ea on master
                            • Discussion 4
                            • Commits 7
                            • Pipelines 8
                            • Changes 2
                            1/1 thread resolved
                            • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 3 weeks ago

                              added scoped labels

                            • Ben Hayward @benhayward.ben changed the description 3 weeks ago

                              changed the description

                            • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

                              added 1 commit

                              • dd210419 - Force tags to lowercase in discovery

                              Compare with previous version

                            • Mark Harding
                              Mark Harding @markeharding started a thread on the diff 2 weeks ago
                              Resolved by Ben Hayward 2 weeks ago
                            • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 2 weeks ago

                              added scoped label and automatically removed label

                            • Ben Hayward @benhayward.ben added 47 commits 2 weeks ago

                              added 47 commits

                              • 9483040f...ecb915ef - 45 commits from branch master
                              • ac4c1ec4 - Merge branch 'master' of gitlab.com:minds/front into fix/upload-cancel-2083
                              • 2444cfdd - Added in missing clientService put

                              Compare with previous version

                            • Ben Hayward @benhayward.ben resolved all threads 2 weeks ago

                              resolved all threads

                            • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 2 weeks ago

                              added scoped label and automatically removed label

                            • Mark Harding
                              Mark Harding @markeharding · 2 weeks ago
                              Owner

                              There are still issues here.

                            • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 2 weeks ago

                              added scoped label and automatically removed label

                            • Mark Harding
                              Mark Harding @markeharding · 2 weeks ago
                              Owner

                              bug

                            • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

                              added 1 commit

                              • 870a33b9 - Call abort regardless to deal with timing issues

                              Compare with previous version

                            • Mark Harding @markeharding approved this merge request 13 minutes ago

                              approved this merge request

                            • Mark Harding @markeharding merged 13 minutes ago

                              merged

                            • Mark Harding @markeharding mentioned in commit 5f0eb8ea 13 minutes ago

                              mentioned in commit 5f0eb8ea

                            Please register or sign in to reply
                            0 Assignees
                            None
                            None
                            Milestone
                            None
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            MR::Requires Changes Squad::Yellow
                            Lock merge request
                            Unlocked
                            10
                            10 participants
                            user avatar
                            Emiliano Balbuena
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Martin Santangelo
                            user avatar
                            Guy Thouret
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Olivia Madrid
                            user avatar
                            Brian Hatchet
                            Reference: minds/front!587