Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
  • Repository
  • Issues 810
  • Merge Requests 54
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !601

Merged
Opened 2 weeks ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/PinkPanther](fix): Check whether $updateMarker exists before unsubscribing #1982

Summary

Issue in sentry at https://sentry.io/organizations/minds-inc/issues/1210702781/?project=1538008&referrer=gitlab_integration

Seems to be that if the updateMarker$ object does not exist an error is thrown.

Testing

Not sure of a method to replicate the issue.

Request to merge fix/update-markers-destroy-unsubscribe-1982 into master
Pipeline #89561561 passed with warnings for a405ea36 on fix/update-markers-destroy-unsubscribe-1982
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller

              Merged by Mark Harding 19 minutes ago

              The changes were merged into master with baccdf54

              The source branch has been deleted

              Mentions #1982

              Pipeline #93454904 running for baccdf54 on master
                            • Discussion 0
                            • Commits 1
                            • Pipelines 1
                            • Changes 1
                            • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 2 weeks ago

                              added scoped labels

                            • Mark Harding @markeharding approved this merge request 19 minutes ago

                              approved this merge request

                            • Mark Harding @markeharding merged 19 minutes ago

                              merged

                            • Mark Harding @markeharding mentioned in commit baccdf54 19 minutes ago

                              mentioned in commit baccdf54

                            Please register or sign in to reply
                            0 Assignees
                            None
                            None
                            Milestone
                            None
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            MR::Awaiting Review Squad::Yellow
                            Lock merge request
                            Unlocked
                            10
                            10 participants
                            user avatar
                            Emiliano Balbuena
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Martin Santangelo
                            user avatar
                            Guy Thouret
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Olivia Madrid
                            user avatar
                            Brian Hatchet
                            Reference: minds/front!601