Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
  • Repository
  • Issues 295
  • Merge Requests 45
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !380

Open
Opened 1 week ago by Marcelo Rivera@eiennohi
Report abuse

Implement new delete for channel delete to record delete event in elasticsearch

closes https://gitlab.com/minds/analytics/issues/32

Request to merge feat/new-delete-event-32 into master
The source branch is 13 commits behind the target branch
Open in Web IDE
Pipeline #90213920 passed for 80522e2f on feat/new-delete-event-32
          Requires 3 more approvals from Devs, Deployers, and QA.
          Emiliano Balbuena
          Emiliano Balbuena
          Martin Santangelo
          Martin Santangelo
          Guy Thouret
          Guy Thouret
          Mark Harding
          Mark Harding
          Olivia Madrid
          Olivia Madrid
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Deletes source branch

          • Discussion 1
          • Commits 1
          • Pipelines 3
          • Changes 3
          0/1 thread resolved
          • Marcelo Rivera @eiennohi changed milestone to %Misc. Q4 2019 1 week ago

            changed milestone to %Misc. Q4 2019

          • Marcelo Rivera @eiennohi added Squad::Yellow scoped label 1 week ago

            added scoped label

          • Marcelo Rivera @eiennohi added 1 commit 1 week ago

            added 1 commit

            • 53e1f9cb - (fix): remove 'phpspec' as pagingStateToken in tests

            Compare with previous version

          • Marcelo Rivera @eiennohi added 1 commit 1 week ago

            added 1 commit

            • 80522e2f - (feat): add new MetricsDelegate that pushes the new delete analytics event

            Compare with previous version

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 45 minutes ago
            Core/Channels/Manager.php
            132 138 if (!$done) {
            133 139 throw new \Exception("{$delegateClassName} deletion failed for {$userGuid}");
            134 140 }
            141
            142 $this->metricsDelegate->onDelete($this->user);
            • Mark Harding
              Mark Harding @markeharding · 45 minutes ago
              Owner

              This is going to lots of entries because its in the foreach? Should it not be below with the logout delegate?

            • Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes scoped label 45 minutes ago

            added scoped label

          Please register or sign in to reply
          0 Assignees
          None
          Misc. Q4 2019
          Milestone
          Misc. Q4 2019
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Requires Changes Squad::Yellow
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Emiliano Balbuena
          user avatar
          Martin Santangelo
          user avatar
          Guy Thouret
          user avatar
          Mark Harding
          user avatar
          Olivia Madrid
          user avatar
          Brian Hatchet
          user avatar
          Rami Albatal
          Reference: minds/engine!380