[Sprint/QuietQuail](feat) Rich embed open in media modals #2162
Summary
Opening youtube videos in modals.
Testing
This has the potential to affect
My test plan (note gifs aren't working at present on sandboxes): Visit: https://feat-rich-embed-modals-2162.minds.io/richembedtest/
- Click through the content.
- Test in groups, comments and discovery>latest.
- Flip the feature flag via helm (any help, let me know).
- Refresh and check that everything still works
Try a variety of content.
added scoped labels
changed title from WIP: Rich embed open in media modals 2162 to WIP: Rich embed open in media modals 2162
added 1 commit
- 12dc5478 - Putting things behind feat flags and tidying
Resolved by Ben Haywardresolved all threads
changed the description
added 2 commits
unmarked as a Work In Progress
added scoped label and automatically removed label
mentioned in issue #2165 (closed)
203 232 204 233 if (this.redirectUrl) { 205 234 this.pageUrl = this.redirectUrl; 206 } else if (this.contentType !== 'blog') { 207 this.pageUrl = `/media/${this.entity.entity_guid}`; 235 } else if (this.contentType === 'rich-embed') { 236 this.pageUrl = `/newsfeed/${this.entity.guid}`; 208 237 } else { 209 this.pageUrl = this.entity.route 210 ? `/${this.entity.route}` 211 : `/blog/view${this.entity.guid}`; ![Mark Harding](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
OwnerSupport for blog still?
added scoped label and automatically removed label
- Owner
Looking good so far. The description/title looks to be overflowing (potentially just remove this?).
https://feat-rich-embed-modals-2162.minds.io/newsfeed/1038021148513669138
