Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
  • Repository
  • Issues 818
  • Merge Requests 63
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !608

Open
Opened 2 weeks ago by Emiliano Balbuena@edgebal29 of 31 tasks completed29/31 tasks
Report abuse

WIP: Product pages update

  • Plus page contents
  • Pro page contents
  • Nodes page contents
  • Upgrades page contents update
  • Pay page contents
  • Rewards page contents
  • Token page contents
  • Boost page contents
  • Footer layout and style update (desktop and mobile, light and dark)
  • Style 3 foundations (desktop and mobile, light and dark)
  • Style 4 foundations (desktop and mobile, light and dark)
  • Style Tail foundations (desktop and mobile, light and dark)
  • Plus page assets
  • Pro page assets
  • Nodes page assets
  • Pay page assets
  • Rewards page assets
  • Token page assets
  • Boost page assets
  • Style 3 decoration
  • Style 4 decoration
  • Style tail separators
  • Nodes page actions
  • Pay page actions
  • Rewards page actions
  • Boost page actions
  • Rewards page dynamic values
  • Buy token component
  • E2E Tests for product pages
  • Review footer link destinations
  • Final Boost page content (follow up #2037)

Issues

  • Closes #2037
  • Closes #2108
  • Closes #2141
  • Closes #2142
Edited 14 hours ago by Emiliano Balbuena
Request to merge goal/product-pages-update-1 into master
Open in Web IDE
Pipeline #93167402 passed with warnings for 17b77c45 on goal/product-pages-update-1
              Requires 3 more approvals from Devs, Deployers, and QA.
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Depends on 1 merge request being merged
              This is a Work in Progress

              Closes #2037, #2108, #2141, and #2142

              Deletes source branch

              You can merge this merge request manually using the
              • Discussion 1
              • Commits 27
              • Pipelines 22
              • Changes 127
              0/1 thread resolved
              • Emiliano Balbuena @edgebal changed milestone to %Pro Beta #release 2 weeks ago

                changed milestone to %Pro Beta #release

              • Emiliano Balbuena @edgebal added Squad::Yellow scoped label 2 weeks ago

                added scoped label

              • Emiliano Balbuena @edgebal changed the description 2 times within 4 minutes 2 weeks ago

                changed the description 2 times within 4 minutes

              • Emiliano Balbuena @edgebal added 2 commits 1 week ago

                added 2 commits

                • 1c40fdda - (chore): never call the legacy categories modal - 2124
                • 41534fed - App changes to support Angular Hot Module Reloading for dev env

                Compare with previous version

              • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                added 1 commit

                • 9142411a - (chore): Blockchain marketing pages content

                Compare with previous version

              • Emiliano Balbuena @edgebal added 4 commits 1 week ago

                added 4 commits

                • 9142411a...66944378 - 3 commits from branch master
                • 70df5d64 - Merge remote-tracking branch 'origin/master' into goal/product-pages-update-1

                Compare with previous version

              • Emiliano Balbuena @edgebal marked the task Pay page contents as completed 1 week ago

                marked the task Pay page contents as completed

              • Emiliano Balbuena @edgebal marked the task Rewards page contents as completed 1 week ago

                marked the task Rewards page contents as completed

              • Emiliano Balbuena @edgebal marked the task Token page contents as completed 1 week ago

                marked the task Token page contents as completed

              • Emiliano Balbuena @edgebal added 6h of time spent at 2019-10-21 1 week ago

                added 6h of time spent at 2019-10-21

              • Emiliano Balbuena @edgebal removed time spent 1 week ago

                removed time spent

              • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                added 1 commit

                • 95918ed3 - (wip): Styles split/style 3

                Compare with previous version

              • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                added 1 commit

                • f106ce12 - (feat): Style 3; style 4; style tail

                Compare with previous version

              • Emiliano Balbuena @edgebal changed the description 1 week ago

                changed the description

              • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                added 1 commit

                • 430074c4 - (feat): Token, Plus, Pro, Nodes imagery

                Compare with previous version

              • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                added 1 commit

                • 03673a03 - (feat): Pay and Rewards imagery

                Compare with previous version

              • Emiliano Balbuena @edgebal changed the description 1 week ago

                changed the description

              • Emiliano Balbuena @edgebal added 2 commits 1 week ago

                added 2 commits

                • 231a45ac - (feat): Style tail decoration
                • acc30fa5 - (fix): Marketing point value emphasis

                Compare with previous version

              • Emiliano Balbuena @edgebal marked the task Style 3 decoration as completed 1 week ago

                marked the task Style 3 decoration as completed

              • Emiliano Balbuena @edgebal marked the task Style 4 decoration as completed 1 week ago

                marked the task Style 4 decoration as completed

              • Emiliano Balbuena @edgebal marked the task Style tail separators as completed 1 week ago

                marked the task Style tail separators as completed

              • Emiliano Balbuena @edgebal marked the task Boost page contents as completed 1 week ago

                marked the task Boost page contents as completed

              • Emiliano Balbuena @edgebal marked the task Boost page assets as completed 1 week ago

                marked the task Boost page assets as completed

              • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                added 1 commit

                • e787b240 - (feat): Boost page contents and imagery

                Compare with previous version

              • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                added 1 commit

                • 6b5ad0bc - (feat): Style 2 and 3 decoration artifacts

                Compare with previous version

              • Emiliano Balbuena @edgebal added 3 commits 1 week ago

                added 3 commits

                • 6b5ad0bc...5e3c86ef - 2 commits from branch master
                • d2649b1e - Merge remote-tracking branch 'origin/master' into goal/product-pages-update-1

                Compare with previous version

              • Emiliano Balbuena @edgebal changed the description 1 week ago

                changed the description

              • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                added 1 commit

                • c57609f8 - (fix): Correct shadows in UX sample images on product pages

                Compare with previous version

              • Emiliano Balbuena @edgebal added 2 commits 1 week ago

                added 2 commits

                • 3bfdb21a - (fix): Fix inter-section spacing
                • 6e09929c - (feat): Use dynamic values when showing contribution on product page

                Compare with previous version

              • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                added 1 commit

                • aeab3d4b - (feat): Product pages button actions

                Compare with previous version

              • Emiliano Balbuena @edgebal marked the task Nodes page actions as completed 1 week ago

                marked the task Nodes page actions as completed

              • Emiliano Balbuena @edgebal marked the task Pay page actions as completed 1 week ago

                marked the task Pay page actions as completed

              • Emiliano Balbuena @edgebal marked the task Rewards page actions as completed 1 week ago

                marked the task Rewards page actions as completed

              • Emiliano Balbuena @edgebal marked the task Boost page actions as completed 1 week ago

                marked the task Boost page actions as completed

              • Emiliano Balbuena @edgebal marked the task Rewards page dynamic values as completed 1 week ago

                marked the task Rewards page dynamic values as completed

              • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                added 1 commit

                • 49345cb7 - (chore): Analytics SEO banner

                Compare with previous version

              • Emiliano Balbuena @edgebal added 5 commits 1 week ago

                added 5 commits

                • 49345cb7...d66805df - 4 commits from branch master
                • 7e932b8b - Merge remote-tracking branch 'origin/master' into goal/product-pages-update-1

                Compare with previous version

              • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                added 1 commit

                • 46094e5c - (feat): Re-introduce the ability to buy tokens

                Compare with previous version

              • Emiliano Balbuena @edgebal marked the task Buy token component as completed 1 week ago

                marked the task Buy token component as completed

              • Marcelo Rivera @eiennohi mentioned in merge request !623 2 days ago

                mentioned in merge request !623

              • Emiliano Balbuena @edgebal added 3 commits 1 day ago

                added 3 commits

                • 46094e5c...80069206 - 2 commits from branch master
                • 4fe4cdd1 - Merge remote-tracking branch 'origin/master' into goal/product-pages-update-1

                Compare with previous version

              • Emiliano Balbuena @edgebal added 1 commit 17 hours ago

                added 1 commit

                • 20fb225c - (test): E2E for /upgrades

                Compare with previous version

              • Emiliano Balbuena @edgebal added 1 commit 14 hours ago

                added 1 commit

                • 17b77c45 - (tests): E2E for simple product pages

                Compare with previous version

              • Emiliano Balbuena @edgebal changed the description 14 hours ago

                changed the description

              • Ben Hayward
                Ben Hayward @benhayward.ben started a thread on the diff 14 hours ago
                cypress/integration/upgrades.spec.js
                55 cy.get(anyBuyTokensModal).should('be.visible');
                56 });
                57
                58 it('should have the ability to trigger Buy Eth modal', () => {
                59 const buyEthLink =
                60 'm-blockchain--purchase .m-blockchainTokenPurchase__ethRate a';
                61 const buyEthModal = 'm-blockchain__eth-modal .m-modal-container';
                62
                63 cy.get(buyEthLink).click();
                64
                65 cy.get(buyEthModal).should('be.visible');
                66 });
                67
                68 it('should navigate to Plus and trigger a Wire', () => {
                69 const upgradeButton = cy.get(
                70 '.mf-button.m-upgradesUpgradeOptionsPlan__action:eq(0)'
                • Ben Hayward
                  Ben Hayward @benhayward.ben · 14 hours ago
                  Developer

                  Might be best to change this and the other selectors used here, to a contains or a data-attribute. Unsure what its actually referencing so may be an exception to the rule but indexed selection is our enemy, as it'll break more easily.

                • Please register or sign in to reply
              Please register or sign in to reply
              Assignee
              Emiliano Balbuena's avatar
              Emiliano Balbuena @edgebal
              Pro Beta #release
              Milestone
              Pro Beta #release
              Time tracking
              No estimate or time spent
              1
              Labels
              Squad::Yellow
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Mark Harding
              user avatar
              Martin Santangelo
              user avatar
              Marcelo Rivera
              user avatar
              Juan Manuel Solaro
              user avatar
              Olivia Madrid
              user avatar
              Guy Thouret
              user avatar
              Brian Hatchet
              Reference: minds/front!608