Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 266
    • Issues 266
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 42
    • Merge Requests 42
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !347

Merged
Opened 3 weeks ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/OldfashionedOwl](fix): Subscription feed upgrade #435

Closes #435 (closed) Depends on !347 (merged)

Summary

This page was using some very old code, so I've upgraded it to use the paging tokens. This should avoid situations like this: https://www.minds.com/kratommotivation1/subscriptions

Testing

To test, pick a user with some subscriptions, and visit /{user}/subscriptions.

Click through subscriptions and subscribers, scroll up and down. https://fix-subscription-feed-435.minds.io/

For bonus points, deploy against live data and check: https://www.minds.com/kratommotivation1/subscriptions

Edited 19 hours ago by Ben Hayward
Request to merge fix/subscription-feed-435 into master
  • Email patches
  • Plain diff
Pipeline #88692797 failed for b0e688e8 on fix/subscription-feed-435
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Emiliano Balbuena
          Emiliano Balbuena
          Rami Albatal
          Rami Albatal
          Martin Santangelo
          Martin Santangelo
          Marcelo Rivera
          Marcelo Rivera
          Brian Hatchet
          Brian Hatchet

          Merged by Mark Harding 52 minutes ago

          The changes were merged into master with 4300e1a6

          The source branch has been deleted

          Closed #435 (closed)

          Pipeline #89729146 failed for 4300e1a6 on master
                        • Discussion 6
                        • Commits 5
                        • Pipelines 3
                        • Changes 5
                        3/3 threads resolved
                        • Loading...
                        • Ben Hayward @benhayward.ben added Squad::Yellow scoped label 3 weeks ago

                          added Squad::Yellow scoped label

                        • Ben Hayward @benhayward.ben added 1 commit 3 weeks ago

                          added 1 commit

                          • 0f12af4c - Updated

                          Compare with previous version

                        • Ben Hayward @benhayward.ben unmarked as a Work In Progress 3 weeks ago

                          unmarked as a Work In Progress

                        • Ben Hayward @benhayward.ben changed the description 3 weeks ago

                          changed the description

                        • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label 3 weeks ago

                          added MR::Awaiting Review scoped label

                        • Mark Harding
                          Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                          Resolved by Ben Hayward 19 hours ago
                        • Mark Harding
                          Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                          Resolved by Ben Hayward 3 days ago
                        • Mark Harding
                          Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                          Resolved by Ben Hayward 3 days ago
                        • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 week ago

                          added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

                        • Ben Hayward @benhayward.ben resolved all threads 3 days ago

                          resolved all threads

                        • Ben Hayward @benhayward.ben added 44 commits 3 days ago

                          added 44 commits

                          • 0f12af4c...142d395f - 41 commits from branch master
                          • 1aa0d7f1 - Updated for feedback
                          • 7de7bcb6 - Merge branch 'master' of gitlab.com:minds/engine into fix/subscription-feed-435
                          • b0e688e8 - Updated tests

                          Compare with previous version

                          Toggle commit list
                        • Ben Hayward @benhayward.ben resolved all threads 3 days ago

                          resolved all threads

                        • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 3 days ago

                          added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

                        • Mark Harding
                          Mark Harding @markeharding · 1 day ago
                          Owner

                          Getting infinite loops at https://revolver.minds.com/sillysealion5/subscriptions

                        • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 day ago

                          added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

                        • Ben Hayward @benhayward.ben mentioned in merge request front!599 (merged) 19 hours ago

                          mentioned in merge request front!599 (merged)

                        • Ben Hayward @benhayward.ben changed the description 19 hours ago

                          changed the description

                        • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 19 hours ago

                          added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

                        • Ben Hayward @benhayward.ben resolved all threads 19 hours ago

                          resolved all threads

                        • Ben Hayward
                          Ben Hayward @benhayward.ben · 19 hours ago
                          Developer

                          Should be fixed with !347 (merged)

                        • Mark Harding @markeharding approved this merge request 52 minutes ago

                          approved this merge request

                        • Mark Harding @markeharding merged 52 minutes ago

                          merged

                        • Mark Harding @markeharding mentioned in commit 4300e1a6 52 minutes ago

                          mentioned in commit 4300e1a6

                        • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                        Please register or sign in to reply
                        0 Assignees
                        None
                        Assign to
                        None
                        Milestone
                        None
                        Assign milestone
                        None
                        Time tracking
                        No estimate or time spent
                        2
                        Labels
                        MR::Awaiting Review Squad::Yellow
                        Assign labels
                        • View project labels
                        Lock merge request
                        Unlocked
                        10
                        10 participants
                        user avatar
                        Emiliano Balbuena
                        user avatar
                        Rami Albatal
                        user avatar
                        Martin Santangelo
                        user avatar
                        Marcelo Rivera
                        user avatar
                        Brian Hatchet
                        user avatar
                        Olivia Madrid
                        user avatar
                        Guy Thouret
                        Reference: minds/engine!347

                        Revert this merge request

                        This will create a new commit in order to revert the existing changes.

                        Switch branch
                        Cancel
                        A new branch will be created in your fork and a new merge request will be started.

                        Cherry-pick this merge request

                        Switch branch
                        Cancel
                        A new branch will be created in your fork and a new merge request will be started.