Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 829
    • Issues 829
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 47
    • Merge Requests 47
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !601

Open
Opened 55 minutes ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/PinkPanther](fix): Check whether $updateMarker exists before unsubscribing #1982

Summary

Issue in sentry at https://sentry.io/organizations/minds-inc/issues/1210702781/?project=1538008&referrer=gitlab_integration

Seems to be that if the updateMarker$ object does not exist an error is thrown.

Testing

Not sure of a method to replicate the issue.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "fix/update-markers-destroy-unsubscribe-1982" "origin/fix/update-markers-destroy-unsubscribe-1982"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "fix/update-markers-destroy-unsubscribe-1982"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/update-markers-destroy-unsubscribe-1982 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #89561561 running for a405ea36 on fix/update-markers-destroy-unsubscribe-1982
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena
              Emiliano Balbuena
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Mentions #1982

              Deletes source branch

              • Discussion 0
              • Commits 1
              • Pipelines 1
              • Changes 1
              • Loading...
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 55 minutes ago

                added MR::Awaiting Review Squad::Yellow scoped labels

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Yellow
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Emiliano Balbuena
              user avatar
              Mark Harding
              user avatar
              Guy Thouret
              user avatar
              Juan Manuel Solaro
              user avatar
              Olivia Madrid
              user avatar
              Martin Santangelo
              user avatar
              Brian Hatchet
              Reference: minds/front!601