Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 238
    • Issues 238
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 42
    • Merge Requests 42
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !372

Closed
Opened 23 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

WIP: [Sprint/PinkPanther](fix): Better handling of 'user not found' state at v1/groups/member. #871

Closes #871

Summary

Not entirely sure how to replicate this, as if you're not logged in the request should return "Not authenticated etc". That said following it down the stack to the endpoint that is passing in a null user GUID, and taking logic from another part of the site for 'null user handling' makes the most sense to me.

Edited 22 hours ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "fix/update-markers-no-user-guid-871" "origin/fix/update-markers-no-user-guid-871"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "fix/update-markers-no-user-guid-871"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/update-markers-no-user-guid-871 into master
  • Email patches
  • Plain diff
Pipeline #89285579 passed for 2ebc3184 on fix/update-markers-no-user-guid-871
          Requires 3 more approvals from Devs, Deployers, and QA.
          Emiliano Balbuena
          Emiliano Balbuena
          Mark Harding
          Mark Harding
          Guy Thouret
          Guy Thouret
          Olivia Madrid
          Olivia Madrid
          Rami Albatal
          Rami Albatal

          Closed by Ben Hayward 18 minutes ago

          The changes were not merged into master

          Did not close #871

          Deletes source branch

          • Discussion 1
          • Commits 1
          • Pipelines 1
          • Changes 2
          • Loading...
          • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 23 hours ago

            added MR::Awaiting Review Squad::Yellow scoped labels

          • Ben Hayward @benhayward.ben marked as a Work In Progress 22 hours ago

            marked as a Work In Progress

          • Ben Hayward @benhayward.ben changed the description 22 hours ago

            changed the description

          • Ben Hayward
            Ben Hayward @benhayward.ben · 22 hours ago
            Developer

            Will chat about this tomorrow

          • Ben Hayward @benhayward.ben closed 18 minutes ago

            closed

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Awaiting Review Squad::Yellow
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Emiliano Balbuena
          user avatar
          Mark Harding
          user avatar
          Guy Thouret
          user avatar
          Olivia Madrid
          user avatar
          Rami Albatal
          user avatar
          Martin Santangelo
          user avatar
          Brian Hatchet
          Reference: minds/engine!372