Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 238
    • Issues 238
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 43
    • Merge Requests 43
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !371

Merged
Opened 23 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/PinkPanther](fix): Return error if the provided group is not found by group report. #874

Closes #874 (closed)

Summary

Noticed from Sentry, this endpoint was getting called with an invalid user.

Test

Hit http://{{host}}/api/v1/groups/review/1020865576266620928/count with an invalid group ID. (if you're on postman you can go to Ben's\ Corner/api/groups/groups\ v1\ reported)

Reproducing the bug locally

image

New request after fix

image

Request to merge fix/group-report-invalid-group-874 into master
  • Email patches
  • Plain diff
Pipeline #89277069 passed for 62d30d40 on fix/group-report-invalid-group-874
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Emiliano Balbuena
          Emiliano Balbuena
          Rami Albatal
          Rami Albatal
          Guy Thouret
          Guy Thouret
          Olivia Madrid
          Olivia Madrid
          Martin Santangelo
          Martin Santangelo

          Merged by Mark Harding 2 hours ago

          The changes were merged into master with 1802d07d

          The source branch has been deleted

          Closed #874 (closed)

          Pipeline #89499590 waiting for manual action for 1802d07d on master
                        • Discussion 0
                        • Commits 1
                        • Pipelines 1
                        • Changes 1
                        • Loading...
                        • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 23 hours ago

                          added MR::Awaiting Review Squad::Yellow scoped labels

                        • Mark Harding @markeharding approved this merge request 2 hours ago

                          approved this merge request

                        • Mark Harding @markeharding mentioned in commit 1802d07d 2 hours ago

                          mentioned in commit 1802d07d

                        • Mark Harding @markeharding merged 2 hours ago

                          merged

                        • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                        Please register or sign in to reply
                        0 Assignees
                        None
                        Assign to
                        None
                        Milestone
                        None
                        Assign milestone
                        None
                        Time tracking
                        No estimate or time spent
                        2
                        Labels
                        MR::Awaiting Review Squad::Yellow
                        Assign labels
                        • View project labels
                        Lock merge request
                        Unlocked
                        10
                        10 participants
                        user avatar
                        Emiliano Balbuena
                        user avatar
                        Rami Albatal
                        user avatar
                        Guy Thouret
                        user avatar
                        Olivia Madrid
                        user avatar
                        Martin Santangelo
                        user avatar
                        Brian Hatchet
                        user avatar
                        Marcelo Rivera
                        Reference: minds/engine!371

                        Revert this merge request

                        This will create a new commit in order to revert the existing changes.

                        Switch branch
                        Cancel
                        A new branch will be created in your fork and a new merge request will be started.

                        Cherry-pick this merge request

                        Switch branch
                        Cancel
                        A new branch will be created in your fork and a new merge request will be started.