Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 829
    • Issues 829
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 45
    • Merge Requests 45
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !589

Merged
Opened 2 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/PinkPanther](feat): Force hashtag pipe to lowercase in discovery #2088

Closes #2088 (closed)

Summary

When clicking a hashtag from a post, this forces the querystring to take the hashtag in as lowercase. On production right now; clicking #NAME would send you to /newsfeed/global/top;hashtag=NAME;period=24h, and we want /newsfeed/global/top;hashtag=name;period=24h

Testing

Try variations on capitalising tags and clicking them, it should link through and relevant content should be found.

Request to merge feat/lowercase-tag-discovery-2088 into master
  • Email patches
  • Plain diff
Pipeline #88755467 passed for 5992d6ae on feat/lowercase-tag-discovery-2088
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller

              Merged by Mark Harding 3 hours ago

              The changes were merged into master with ecb915ef

              The source branch has been deleted

              Closed #2088 (closed)

              Pipeline #89485870 failed for ecb915ef on master
                            • Discussion 0
                            • Commits 1
                            • Pipelines 1
                            • Changes 2
                            • Loading...
                            • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 2 days ago

                              added MR::Awaiting Review Squad::Yellow scoped labels

                            • Mark Harding @markeharding approved this merge request 3 hours ago

                              approved this merge request

                            • Mark Harding @markeharding enabled an automatic merge when the pipeline for 5992d6ae succeeds 3 hours ago

                              enabled an automatic merge when the pipeline for 5992d6ae succeeds

                            • Mark Harding @markeharding merged 3 hours ago

                              merged

                            • Mark Harding @markeharding mentioned in commit ecb915ef 3 hours ago

                              mentioned in commit ecb915ef

                            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                            Please register or sign in to reply
                            0 Assignees
                            None
                            Assign to
                            None
                            Milestone
                            None
                            Assign milestone
                            None
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            MR::Awaiting Review Squad::Yellow
                            Assign labels
                            • View project labels
                            Lock merge request
                            Unlocked
                            10
                            10 participants
                            user avatar
                            Emiliano Balbuena
                            user avatar
                            Guy Thouret
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Olivia Madrid
                            user avatar
                            Martin Santangelo
                            user avatar
                            Brian Hatchet
                            user avatar
                            Marcelo Rivera
                            Reference: minds/front!589

                            Revert this merge request

                            This will create a new commit in order to revert the existing changes.

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.

                            Cherry-pick this merge request

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.