Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 827
    • Issues 827
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 44
    • Merge Requests 44
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !557

Merged
Opened 4 weeks ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/NuancedNumbat](fix): Fixed width of avatars.

Closes #1913 (closed)#

Upload an avatar and check it out around the site. Make sure its not warped anywhere. Send a notification to a second test user, make sure your picture shows up okay.

image

ideally I'd deploy this on a network linked into production so that I can test this specific user, as uploading the image he posted, does not emulate the effect of the wide avatar that he has.

Edited 4 weeks ago by Ben Hayward
Request to merge fix/max-avatar-width-1913 into master
  • Email patches
  • Plain diff
Pipeline #88066575 passed with warnings for 225e1a45 on fix/max-avatar-width-1913
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet

              Merged by Mark Harding 2 hours ago

              The changes were merged into master with ab30fde2

              The source branch has been deleted

              Closed #1913 (closed)

              Pipeline #89477035 waiting for manual action for ab30fde2 on master
                            • Discussion 8
                            • Commits 3
                            • Pipelines 3
                            • Changes 3
                            0/2 threads resolved
                            • Loading...
                            • Ben Hayward @benhayward.ben changed the description 4 weeks ago

                              changed the description

                            • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 4 weeks ago

                              added MR::Awaiting Review Squad::Yellow scoped labels

                            • Ben Hayward @benhayward.ben added 25 commits 3 weeks ago

                              added 25 commits

                              • c9ab0fb1...3ea249c0 - 24 commits from branch master
                              • 4691ed22 - Merge branch 'master' of gitlab.com:minds/front into fix/max-avatar-width-1913

                              Compare with previous version

                            • Emiliano Balbuena @edgebal approved this merge request 3 weeks ago

                              approved this merge request

                            • Emiliano Balbuena
                              Emiliano Balbuena @edgebal · 3 weeks ago
                              Developer

                              @markeharding Can we get this on a testable production environment?

                            • Marcelo Rivera @eiennohi approved this merge request 3 weeks ago

                              approved this merge request

                            • Ben Hayward
                              Ben Hayward @benhayward.ben · 3 weeks ago
                              Developer

                              I cannot see my changes on revolver :thinking:

                            • Ben Hayward
                              Ben Hayward @benhayward.ben · 1 week ago
                              Developer

                              Issue has been closed so closing this MR for now.

                            • Ben Hayward @benhayward.ben closed 1 week ago

                              closed

                            • Ben Hayward @benhayward.ben reopened 1 week ago

                              reopened

                            • Ben Hayward
                              Ben Hayward @benhayward.ben · 1 week ago
                              Developer

                              Was there some feedback for this, the issue got closed then moved into this week so I'm not sure whats happening.

                            • Ben Hayward @benhayward.ben added 1 commit 6 days ago

                              added 1 commit

                              • 225e1a45 - Changed to use object-fit cover

                              Compare with previous version

                            • Mark Harding
                              Mark Harding @markeharding started a thread on the diff 7 hours ago
                              Last updated by Ben Hayward 3 hours ago
                              src/app/modules/notifications/notifications.component.scss
                              15 15
                              16 16 img {
                              17 17 border-radius: 50%;
                              18 max-height: 50px;
                              18 width: 40px;
                              • Mark Harding
                                Mark Harding @markeharding · 7 hours ago
                                Owner

                                should be 50px?

                              • Ben Hayward
                                Ben Hayward @benhayward.ben · 3 hours ago
                                Developer

                                Can be if you want it to be, but looked too big to me

                                40px on right, current production on left: image

                                50px on right, current production on left: image

                              • Please register or sign in to reply
                            • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 7 hours ago

                              added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

                            • Mark Harding
                              Mark Harding @markeharding started a thread on the diff 2 hours ago
                              Last updated by Mark Harding 2 hours ago
                              src/app/modules/notifications/notifications.component.scss
                              15 15
                              16 16 img {
                              17 17 border-radius: 50%;
                              18 max-height: 50px;
                              18 width: 40px;
                              • Mark Harding
                                Mark Harding @markeharding · 2 hours ago
                                Owner

                                But this is a change being made, not a fix right? It was 50px, but you reduced to 40px. Screenshot_2019-10-17_at_13.14.08

                              • Mark Harding
                                Mark Harding @markeharding · 2 hours ago
                                Owner

                                nvm, looks like height of these is actually 40px

                              • Please register or sign in to reply
                            • Mark Harding @markeharding approved this merge request 2 hours ago

                              approved this merge request

                            • Mark Harding @markeharding merged 2 hours ago

                              merged

                            • Mark Harding @markeharding mentioned in commit ab30fde2 2 hours ago

                              mentioned in commit ab30fde2

                            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                            Please register or sign in to reply
                            0 Assignees
                            None
                            Assign to
                            None
                            Milestone
                            None
                            Assign milestone
                            None
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            MR::Requires Changes Squad::Yellow
                            Assign labels
                            • View project labels
                            Lock merge request
                            Unlocked
                            9
                            9 participants
                            user avatar
                            Emiliano Balbuena
                            user avatar
                            Guy Thouret
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Olivia Madrid
                            user avatar
                            Martin Santangelo
                            user avatar
                            Brian Hatchet
                            user avatar
                            Marcelo Rivera
                            Reference: minds/front!557

                            Revert this merge request

                            This will create a new commit in order to revert the existing changes.

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.

                            Cherry-pick this merge request

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.