Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 837
    • Issues 837
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 46
    • Merge Requests 46
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !594

Open
Opened 1 hour ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

Pro Feeds not working

closes #2107 (closed)

Edited 1 hour ago by Marcelo Rivera

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "fix/filter-issue-in-pro" "origin/fix/filter-issue-in-pro"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "fix/filter-issue-in-pro"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/filter-issue-in-pro into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #89263685 pending for c0afaac3 on fix/filter-issue-in-pro
              Requires 3 more approvals from Devs, Deployers, and QA.
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2107 (closed)

              Deletes source branch

              • Discussion 1
              • Commits 3
              • Pipelines 3
              • Changes 1
              0/1 thread resolved
              • Loading...
              • Marcelo Rivera @eiennohi changed milestone to %Minds Pro #rollout 1 hour ago

                changed milestone to %Minds Pro #rollout

              • Marcelo Rivera @eiennohi added Product::Pro Sprint::10/09 - Pink Panther Squad::Yellow scoped labels 1 hour ago

                added Product::Pro Sprint::10/09 - Pink Panther Squad::Yellow scoped labels

              • Marcelo Rivera @eiennohi changed the description 1 hour ago

                changed the description

              • Marcelo Rivera @eiennohi added 1 commit 44 minutes ago

                added 1 commit

                • 8b5cda32 - fix: trigger pipeline

                Compare with previous version

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 4 minutes ago
                Last updated by Marcelo Rivera 2 minutes ago
                src/app/modules/pro/channel/list/list.component.ts
                85 88 this.period = params['period'] || '';
                86 89 this.selectedHashtag = params['hashtag'] || 'all';
                87 90
                91 this.entities$ = this.feedsService.feed.pipe(
                • Mark Harding
                  Mark Harding @markeharding · 4 minutes ago
                  Owner

                  this should either be in the constructor on even directly on the class.

                • Marcelo Rivera @eiennohi changed this line in version 3 of the diff 2 minutes ago

                  changed this line in version 3 of the diff

                • Please register or sign in to reply
              • Mark Harding @markeharding added MR::Requires Changes scoped label 4 minutes ago

                added MR::Requires Changes scoped label

              • Marcelo Rivera @eiennohi added 1 commit 2 minutes ago

                added 1 commit

                • c0afaac3 - (fix): move subscription to constructor

                Compare with previous version

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              Minds Pro #rollout
              Milestone
              Minds Pro #rollout
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              4
              Labels
              MR::Requires Changes Product::Pro Sprint::10/09 - Pink Panther Squad::Yellow
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Ben Hayward
              user avatar
              Mark Harding
              user avatar
              Martin Santangelo
              user avatar
              Guy Thouret
              user avatar
              Emiliano Balbuena
              user avatar
              Brian Hatchet
              user avatar
              Juan Manuel Solaro
              Reference: minds/front!594