Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 888
    • Issues 888
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 49
    • Merge Requests 49
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !579

Merged
Opened 1 week ago by Olivia Madrid@omadrid18 of 36 tasks completed18/36 tasks
  • Report abuse
Report abuse

Entity centric metrics (analytics v2)

Filter

  • dropdowns beneath chart are now dropups
  • move label to outside top of dropdown
  • compile descriptions into tooltip next to label
  • dropdown width autofit to length of max option
  • focus/blur behaviour

Table

  • add entity switcher
  • remove order field from table columns object
  • add loading spinner
  • update template to prepare for mobile styles
  • fix flex styles

Chart

  • fix hover markers/shapes
  • populate hover info div
  • figure out selectedTimespan subscription so datePipe and tickFormat are dynamic depending on interval
  • fix datePipe not working for custom date format YYYY
  • figure out where y-axis labels went
  • get hoverinfo div to show usd / 100
  • reposition hover info divs so they don't go out of the chart div
  • whyyyy won't you be responsive
  • resize for mobile
  • disable hover events when filters filter is expanded
  • refactor back into 'angular way'
  • check theme before getData()
  • make touch events work like hover events

Metrics

  • update metric hover/active styles
  • change infinity to 100% when metric summary comparison value is zero
  • apply permissions to metrics
  • add description tooltip
  • don't let tooltip overflow hide behind parent
  • implement metric scroller button and offsetX listener

Dashboard

  • make non-admins auto-apply filter channel::self

Filters

  • hide channel filter for now

Search

  • implement channel search

Other

  • finish mobile styles
  • clean up styles
  • do the inline TODO:s
  • change class names to BEM

Will close #1979 (closed) #1931 (closed) #1935 (closed) #1932 (closed)

Edited 42 minutes ago by Mark Harding

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "feat/entity-centric-metrics" "origin/feat/entity-centric-metrics"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/epic/pro-affiliate-launch"
git merge --no-ff "feat/entity-centric-metrics"

Step 4. Push the result of the merge to GitLab

git push origin "epic/pro-affiliate-launch"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/entity-centric-metrics into epic/pro-affiliate-launch
  • Email patches
  • Plain diff
Pipeline #88932524 pending for 71539440 on feat/entity-centric-metrics
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Emiliano Balbuena
              Emiliano Balbuena
              Xander Miller
              Xander Miller

              Merged by Mark Harding 42 minutes ago

              The changes were merged into epic/pro-affiliate-launch with e9eea300

              Pipeline #88932996 canceled for e9eea300 on epic/pro-affiliate-launch
                          • Discussion 0
                          • Commits 25
                          • Pipelines 15
                          • Changes 60
                          • Loading...
                          • Olivia Madrid @omadrid changed milestone to %Analytics #mvp 1 week ago

                            changed milestone to %Analytics #mvp

                          • Olivia Madrid @omadrid added Platform::Browser Priority::2 - Normal Product::Analytics Squad::Blue Type::Feature scoped labels 1 week ago

                            added Platform::Browser Priority::2 - Normal Product::Analytics Squad::Blue Type::Feature scoped labels

                          • Mark Harding @markeharding mentioned in epic &74 1 week ago

                            mentioned in epic &74

                          • Mark Harding @markeharding added 1 commit 1 week ago

                            added 1 commit

                            • 5760aeab - (wip): various fixes for infinite loops

                            Compare with previous version

                          • Mark Harding @markeharding added 1 commit 1 week ago

                            added 1 commit

                            • 4436d02c - (wip): fixes various looping issues and removes combineLatest logic

                            Compare with previous version

                          • Olivia Madrid @omadrid added 2 commits 1 week ago

                            added 2 commits

                            • eece05bc - (feat): analytics v2 - router
                            • 262eb337 - (feat): more analytics v2

                            Compare with previous version

                          • Mark Harding @markeharding added 1 commit 1 week ago

                            added 1 commit

                            • 680f081b - (feat): fixes graph to read production data

                            Compare with previous version

                          • Olivia Madrid @omadrid added 1 commit 1 week ago

                            added 1 commit

                            • 1b70d572 - (feat): analytics v2 channel search

                            Compare with previous version

                          • Olivia Madrid @omadrid added 1 commit 5 days ago

                            added 1 commit

                            • f1b39a30 - (feat): mobile style, metrics scroller

                            Compare with previous version

                          • Olivia Madrid @omadrid added 10 commits 4 days ago

                            added 10 commits

                            • f1b39a30...534f449e - 6 commits from branch master
                            • b61f15f7 - Merge branch 'master' of gitlab.com:minds/front into feat/entity-centric-metrics
                            • 26a8afe0 - (feat): analytics v2 - testing prettyquick error
                            • 9c2268e0 - (feat): analytics v2 - table view
                            • 555b655a - Merge branch 'master' of gitlab.com:minds/front into feat/entity-centric-metrics

                            Compare with previous version

                            Toggle commit list
                          • Mark Harding @markeharding added 1 commit 4 days ago

                            added 1 commit

                            • 170972c1 - (wip): multiple changes to make graphs work with production data

                            Compare with previous version

                          • Olivia Madrid @omadrid added 1 commit 1 day ago

                            added 1 commit

                            • aa2f0263 - (feat): analytics v2 continues

                            Compare with previous version

                          • Olivia Madrid @omadrid changed the description 3 times within 5 minutes 1 day ago

                            changed the description 3 times within 5 minutes

                          • Olivia Madrid @omadrid changed the description 2 times within 1 minute 1 day ago

                            changed the description 2 times within 1 minute

                          • Olivia Madrid @omadrid marked the task apply permissions to metrics as completed 20 hours ago

                            marked the task apply permissions to metrics as completed

                          • Olivia Madrid @omadrid marked the task fix datePipe not working for custom date format YYYY as completed 10 hours ago

                            marked the task fix datePipe not working for custom date format YYYY as completed

                          • Olivia Madrid @omadrid marked the task figure out selectedTimespan subscription so datePipe and tickFormat are dynamic depending on interval as completed 10 hours ago

                            marked the task figure out selectedTimespan subscription so datePipe and tickFormat are dynamic depending on interval as completed

                          • Olivia Madrid @omadrid marked the task hide channel filter for now as completed 10 hours ago

                            marked the task hide channel filter for now as completed

                          • Mark Harding @markeharding added 1 commit 4 hours ago

                            added 1 commit

                            • cace737e - (chore): various fixes

                            Compare with previous version

                          • Olivia Madrid @omadrid marked the task move label to outside top of dropdown as completed 4 hours ago

                            marked the task move label to outside top of dropdown as completed

                          • Olivia Madrid @omadrid marked the task compile descriptions into tooltip next to label as completed 4 hours ago

                            marked the task compile descriptions into tooltip next to label as completed

                          • Olivia Madrid @omadrid marked the task figure out where y-axis labels went as completed 4 hours ago

                            marked the task figure out where y-axis labels went as completed

                          • Olivia Madrid @omadrid marked the task make non-admins auto-apply filter channel::self as completed 4 hours ago

                            marked the task make non-admins auto-apply filter channel::self as completed

                          • Olivia Madrid @omadrid changed the description 4 hours ago

                            changed the description

                          • Olivia Madrid @omadrid added 2 commits 3 hours ago

                            added 2 commits

                            • 64354e9c - (feat): analytics v2 tuning
                            • b00708d6 - Merge remote-tracking branch 'refs/remotes/origin/feat/entity-centric-metrics'...

                            Compare with previous version

                          • Mark Harding @markeharding added 1 commit 2 hours ago

                            added 1 commit

                            • f79e7150 - (chore): more fixes with production data

                            Compare with previous version

                          • Mark Harding @markeharding added 1 commit 1 hour ago

                            added 1 commit

                            • d8b2b46b - (fix): bad import for specs

                            Compare with previous version

                          • Mark Harding @markeharding added 1 commit 44 minutes ago

                            added 1 commit

                            • 71539440 - (chore): exit out of failing tests

                            Compare with previous version

                          • Mark Harding @markeharding changed target branch from master to epic/pro-affiliate-launch 42 minutes ago

                            changed target branch from master to epic/pro-affiliate-launch

                          • Mark Harding @markeharding unmarked as a Work In Progress 42 minutes ago

                            unmarked as a Work In Progress

                          • Mark Harding @markeharding approved this merge request 42 minutes ago

                            approved this merge request

                          • Mark Harding @markeharding mentioned in commit e9eea300 42 minutes ago

                            mentioned in commit e9eea300

                          • Mark Harding @markeharding merged 42 minutes ago

                            merged

                          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                          Please register or sign in to reply
                          0 Assignees
                          None
                          Assign to
                          Analytics #mvp
                          Milestone
                          Analytics #mvp
                          Assign milestone
                          None
                          Time tracking
                          No estimate or time spent
                          5
                          Labels
                          Platform::Browser Priority::2 - Normal Product::Analytics Squad::Blue Type::Feature
                          Assign labels
                          • View project labels
                          Lock merge request
                          Unlocked
                          10
                          10 participants
                          user avatar
                          Martin Santangelo
                          user avatar
                          Juan Manuel Solaro
                          user avatar
                          Marcelo Rivera
                          user avatar
                          Guy Thouret
                          user avatar
                          Brian Hatchet
                          user avatar
                          Ben Hayward
                          user avatar
                          Emiliano Balbuena
                          Reference: minds/front!579

                          Revert this merge request

                          This will create a new commit in order to revert the existing changes.

                          Switch branch
                          Cancel
                          A new branch will be created in your fork and a new merge request will be started.

                          Cherry-pick this merge request

                          Switch branch
                          Cancel
                          A new branch will be created in your fork and a new merge request will be started.