Next

Closes #1732 (closed)

I believe this to be the correct way to take care of it, as the remaining line after deletion caused by border offers an indicator of where the post was. Can be taken care of if anybody disagree's - easy enough to add conditional css but I left it in because it felt better to me.

It appears that the _deleted event emitter is not implemented properly, but I don't feel deferring 'deletion' to the parent is the correct solution anyway.

Note in the HTML file, all I have done is wrapped it in an ng-container conditionally tied to whether the post is in a deleted or not. The large amount of changes come from adjusting the indentation.

added MR::Awaiting Review Squad::Yellow scoped labels

added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

Failing at build step here

Thanks for pointing this out. I'd thought it was the CI as it doesn't run for me running the standand npm run build-dev, running with the aot flag however returns the error.

added 17 commits

• a3316300...d202f657 - 16 commits from branch master
• c39e93ae - Added deleted to reminds and previews as they share the same template

Compare with previous version

Ah I see, the template activity.html is shared by a few controllers.

added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

Issue is now resolved.

closed