Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 886
    • Issues 886
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 49
    • Merge Requests 49
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !539

Closed
Opened 1 month ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

WIP: [Sprint/ModestMonkey](feat): Wallet 2.0 Base

** WORK IN PROGRESS **

Closes #1616 (closed)

To test, head over to /wallet/new, and then to the wallet settings tab where I've included a quick-menu for development purposes only.

** Update ** Holds the completion of the onchain section, verify phone, and core scaffolding. Will use this iteration as the base due to a file structure restructure that would make it more difficult to review individually.

Edited 1 month ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "feat/wallet-redesign-onchain-1616" "origin/feat/wallet-redesign-onchain-1616"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "feat/wallet-redesign-onchain-1616"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/wallet-redesign-onchain-1616 into master
  • Email patches
  • Plain diff
Pipeline #81325509 passed with warnings for 29e30abb on feat/wallet-redesign-onchain-1616
              Requires 2 more approvals from Devs and Deployers.
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Emiliano Balbuena
              Emiliano Balbuena

              Closed by Ben Hayward 1 hour ago

              The changes were not merged into master

              Did not close #1616 (closed)

              Deletes source branch

              • Discussion 1
              • Commits 8
              • Pipelines 3
              • Changes 25
              • Loading...
              • Ben Hayward @benhayward.ben added 52 commits 1 month ago

                added 52 commits

                • 52fb2d90...efca49c0 - 50 commits from branch master
                • bf5660ce - Merge branch 'master' of gitlab.com:minds/front into feat/wallet-redesign-onchain-1616
                • 2bdd75db - Refactored and added in onchain section

                Compare with previous version

              • Ben Hayward @benhayward.ben changed the description 2 times within 2 minutes 1 month ago

                changed the description 2 times within 2 minutes

              • Ben Hayward @benhayward.ben added 1 commit 1 month ago

                added 1 commit

                • 29e30abb - This will need heavily rewriting

                Compare with previous version

              • Ben Hayward @benhayward.ben mentioned in epic &56 (closed) 1 month ago

                mentioned in epic &56 (closed)

              • Ben Hayward @benhayward.ben changed title from WIP: Feat/wallet redesign onchain 1616 to WIP: {+Sprint/ModestMonkey: Wallet 2.0 Base+} 1 month ago

                changed title from WIP: Feat/wallet redesign onchain 1616 to WIP: {+Sprint/ModestMonkey: Wallet 2.0 Base+}

              • Ben Hayward @benhayward.ben changed the description 1 month ago

                changed the description

              • Ben Hayward
                Ben Hayward @benhayward.ben · 1 hour ago
                Developer

                I believe Mark said this is getting passed over to Blue team, so closing.

              • Ben Hayward @benhayward.ben closed 1 hour ago

                closed

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              0
              Labels
              None
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Guy Thouret
              user avatar
              Olivia Madrid
              user avatar
              Mark Harding
              user avatar
              Juan Manuel Solaro
              user avatar
              Brian Hatchet
              user avatar
              Emiliano Balbuena
              user avatar
              Marcelo Rivera
              Reference: minds/front!539