Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 231
    • Issues 231
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 40
    • Merge Requests 40
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !366

Open
Opened 4 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/PinkPanther](feat): Put unread conversations to top of conversation list

Closes #819

Summary

Unread messages were not appearing top of the messenger list which could lead to lost conversations.

Reproduce

  1. Get 3 browsers open.
  2. Log in to 3 seperate accounts.
  3. All message your main user.
  4. Load your conversation list on the main user, and click the top one.
  5. Close the messenger popup and re-open it. - you should observe that the read user is below the unread.
  6. Experiment, and make sure chronological order is respected, but unread conversations are top.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "feat/unread-messages-to-top-819" "origin/feat/unread-messages-to-top-819"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "feat/unread-messages-to-top-819"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/unread-messages-to-top-819 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #88716383 failed for 280f505e on feat/unread-messages-to-top-819
          Requires 3 more approvals from Devs, Deployers, and QA.
          Guy Thouret
          Guy Thouret
          Olivia Madrid
          Olivia Madrid
          Mark Harding
          Mark Harding
          Rami Albatal
          Rami Albatal
          Brian Hatchet
          Brian Hatchet
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #819

          Deletes source branch

          • Discussion 0
          • Commits 2
          • Pipelines 2
          • Changes 1
          • Loading...
          • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 4 hours ago

            added MR::Awaiting Review Squad::Yellow scoped labels

          • Ben Hayward @benhayward.ben mentioned in issue #924 3 hours ago

            mentioned in issue #924

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Awaiting Review Squad::Yellow
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Guy Thouret
          user avatar
          Olivia Madrid
          user avatar
          Mark Harding
          user avatar
          Rami Albatal
          user avatar
          Brian Hatchet
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          Reference: minds/engine!366