Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 231
    • Issues 231
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 40
    • Merge Requests 40
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !310

Closed
Opened 1 month ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/ModestMonkey](feat): Added in pending boost limit for #591

Helm values helm-charts!9 (closed) Closes #591 (closed)

To test

The simplest way is going to be to log in as admin, then open 2 windows.

  • http://0.0.0.0/minds
  • http://0.0.0.0/admin/boosts

image

Next, make posts numbered 1, 2, 3 and 4 on the newsfeed, and boost them.

On 4, you should receive an error indicating that you have exceeded the pending boost limit.

After this, go to the other window (admin panel), refresh, and approve a boost. Try the boost 4 again, it should let you.

Try approve all, and do 3 fresh boosts.

Edited 1 month ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "feat/pending-boost-limit-591" "origin/feat/pending-boost-limit-591"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "feat/pending-boost-limit-591"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/pending-boost-limit-591 into master
  • Email patches
  • Plain diff
Pipeline #80739607 passed for 03e2d8ad on feat/pending-boost-limit-591
          Requires 2 more approvals from Devs and Deployers.
          Mark Harding
          Mark Harding
          Rami Albatal
          Rami Albatal
          Brian Hatchet
          Brian Hatchet
          Emiliano Balbuena
          Emiliano Balbuena
          Marcelo Rivera
          Marcelo Rivera

          Closed by Ben Hayward 9 minutes ago

          The changes were not merged into master

          Did not close #591 (closed)

          Deletes source branch

          • Discussion 3
          • Commits 2
          • Pipelines 2
          • Changes 4
          1/1 thread resolved
          • Loading...
          • Ben Hayward @benhayward.ben changed the description 1 month ago

            changed the description

          • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Green scoped labels 1 month ago

            added MR::Awaiting Review Squad::Green scoped labels

          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 1 month ago
            Resolved by Ben Hayward 1 month ago
          • Ben Hayward @benhayward.ben added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 month ago

            added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

          • Ben Hayward @benhayward.ben resolved all threads 1 month ago

            resolved all threads

          • Ben Hayward @benhayward.ben changed the description 1 month ago

            changed the description

          • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 month ago

            added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

          • Ben Hayward @benhayward.ben added 1 commit 1 month ago

            added 1 commit

            • 03e2d8ad - updated variable name to better reflect value held

            Compare with previous version

          • Ben Hayward @benhayward.ben changed title from Added in pending boost limit for #591 (closed) to {+Sprint/ModestMonkey: +}Added in pending boost limit for #591 (closed) 1 month ago

            changed title from Added in pending boost limit for #591 (closed) to {+Sprint/ModestMonkey: +}Added in pending boost limit for #591 (closed)

          • Ben Hayward
            Ben Hayward @benhayward.ben · 9 minutes ago
            Developer

            Admin team report no need for these currently, can be re-opened if the need arises.

          • Ben Hayward @benhayward.ben closed 9 minutes ago

            closed

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Awaiting Review Squad::Green
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Mark Harding
          user avatar
          Rami Albatal
          user avatar
          Brian Hatchet
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          user avatar
          Martin Santangelo
          user avatar
          Ben Hayward
          Reference: minds/engine!310