[Sprint/OldfashionedOwl](fix): Subscription feed upgrade #435
Closes #435
Summary
This page was using some very old code, so I've upgraded it to use the paging tokens. This should avoid situations like this: https://www.minds.com/kratommotivation1/subscriptions
Testing
To test, pick a user with some subscriptions, and visit /{user}/subscriptions.
Click through subscriptions and subscribers, scroll up and down. https://fix-subscription-feed-435.minds.io/
For bonus points, deploy against live data and check: https://www.minds.com/kratommotivation1/subscriptions
added Squad::Yellow scoped label
unmarked as a Work In Progress
changed the description
added MR::Awaiting Review scoped label
Last updated by Ben Hayward41 if (!$opts['guid']) { 42 throw new \Exception('GUID is required'); 43 } 44 45 $response = new Response; 46 if ($opts['type'] === 'subscribers') { 47 $statement = "SELECT * FROM friends"; 48 } else { 49 $statement = "SELECT * FROM friendsof"; 50 } 51 52 $where = ["column1 = ?"]; 53 $values = [$opts['guid']]; 54 55 $statement .= " WHERE " . implode(' AND ', $where); 56 $statement .= " ALLOW FILTERING"; - Owner
Why are we using allow filtering?
changed this line in version 3 of the diff
DeveloperSorry, I wasn't fully aware of how performance impacting allow filtering is. Flipped the logic around to search by key, in other table.
- Resolved by Ben Hayward
- Resolved by Ben Hayward
added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label
resolved all threads
added 44 commits
- 0f12af4c...142d395f - 41 commits from branch
master - 1aa0d7f1 - Updated for feedback
- 7de7bcb6 - Merge branch 'master' of gitlab.com:minds/engine into fix/subscription-feed-435
- b0e688e8 - Updated tests
Toggle commit list- 0f12af4c...142d395f - 41 commits from branch
resolved all threads
added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label