WIP: Epic/permissions 28
MR for insight into everything that has changed for permissions
7/10 threads resolved
changed milestone to %Permission #review
added Sprint::09/25 - Oldfashioned Owl Squad::Green scoped labels
mentioned in epic &28
added MR::Requires Changes scoped label
- Resolved by Brian Hatchet
- Last updated by Brian Hatchet
100 105 101 106 $exported = $item->export(...$this->exportArgs); 102 107 108 if ($item && Di::_()->get('Features\Manager')->has('permissions')) { 109 if ($item instanceof FeedSyncEntity && $item->getEntity()) { 110 $entity = $item->getEntity(); 111 } else { 112 $entity = $item; 113 } 114 115 /** @var Manager $permissionsManager */ 116 $permissionsManager = Di::_()->get('Permissions\Manager'); 117 $permissions = $permissionsManager->getList([ - Owner
Why are using a list function for a single entity?
- Developer
Because it's not a single entity per se. You can calculate the permissions for entire permissions at the manager level. We're just using it at the entity level to calculate single ones.
- Developer
I can name it whatever you'd like, just following our manager paradigm
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Last updated by Brian Hatchet
119 150 return $export; 120 151 } 121 152 153 /** 154 * Export the exact permissions for a calculated entity only 155 * 156 * @return array serialized individual permission for an entity 157 */ 158 public function exportPermission($guid): array - Owner
I'm having trouble with this function name, its not clear how it is different from
export()
function. - Developer
I am amenable to a better name.
- Resolved by Brian Hatchet
21 21 * @property-read string $enabled 22 22 */ 23 23 abstract class ElggEntity extends ElggData implements 24 Importable // Allow import of data - Owner
I can't tell what has been changed in this file.
added 18 commits
- d1b2d7a4...142d395f - 17 commits from branch
master
- 29e98b44 - Merge remote-tracking branch 'origin/master' into epic/permissions-28
- d1b2d7a4...142d395f - 17 commits from branch