Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 182
    • Issues 182
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 13
    • Merge Requests 13
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !390

Open
Opened 19 hours ago by Juan Manuel Solaro@juanmsolaro
  • Report abuse
Report abuse

[Sprint/OldfashionedOwl] (fix) shouldBeBlured is not a function

I couldn't reproduce consistently. From discovery, when trying to open an activity, sometimes, gives silent error in console.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "fix/shouldBeBlured-is-not-a-function" "origin/fix/shouldBeBlured-is-not-a-function"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/release/3.11.0"
git merge --no-ff "fix/shouldBeBlured-is-not-a-function"

Step 4. Push the result of the merge to GitLab

git push origin "release/3.11.0"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/shouldBeBlured-is-not-a-function into release/3.11.0
Open in Web IDE
  • Email patches
  • Plain diff
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
Requires 2 more approvals.
Ready to be merged automatically. Ask someone with write access to this repository to merge this request
  • Discussion 1
  • Commits 1
  • Pipelines 1
  • Changes 2
0/1 thread resolved
  • Loading...
  • Martin Santangelo
    Martin Santangelo @msantang78 started a thread on the diff 3 hours ago
    src/newsfeed/activity/Activity.js
    69 70 * Render
    70 71 */
    71 72 render() {
    72 const entity = this.props.entity;
    73 const entity = ActivityModel.isActivity(this.props.entity) ? this.props.entity : ActivityModel.create(this.props.entity);
    • Martin Santangelo
      Martin Santangelo @msantang78 · 3 hours ago
      Maintainer

      I already created a method checkOrCreate() in the BaseModel so you can call directly ActivityModel.checkOrCreate(entity)

      Edited by Martin Santangelo 3 hours ago
    • Please register or sign in to reply
  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
None
Assign to
None
Milestone
None
Assign milestone
None
Time tracking
No estimate or time spent
0
Labels
None
Assign labels
  • View project labels
Lock merge request
Unlocked
2
2 participants
user avatar
Martin Santangelo
user avatar
Juan Manuel Solaro
Reference: minds/mobile-native!390