[Sprint/OldfashionedOwl](fix): Subscription feed upgrade #435
Closes #435
Summary
This page was using some very old code, so I've upgraded it to use the paging tokens. This should avoid situations like this: https://www.minds.com/kratommotivation1/subscriptions
Testing
To test, pick a user with some subscriptions, and visit /{user}/subscriptions.
Click through subscriptions and subscribers, scroll up and down. https://fix-subscription-feed-435.minds.io/
For bonus points, deploy against live data and check: https://www.minds.com/kratommotivation1/subscriptions
added Squad::Yellow scoped label
unmarked as a Work In Progress
changed the description
added MR::Awaiting Review scoped label
41 if (!$opts['guid']) { 42 throw new \Exception('GUID is required'); 43 } 44 45 $response = new Response; 46 if ($opts['type'] === 'subscribers') { 47 $statement = "SELECT * FROM friends"; 48 } else { 49 $statement = "SELECT * FROM friendsof"; 50 } 51 52 $where = ["column1 = ?"]; 53 $values = [$opts['guid']]; 54 55 $statement .= " WHERE " . implode(' AND ', $where); 56 $statement .= " ALLOW FILTERING"; 
OwnerWhy are we using allow filtering?
37 37 { 38 38 return $this->opts; 39 39 } 40 41 public function getTemplate() - Owner
can we get some doc markup and return type
: string?
20 20 } 21 21 22 22 /** 23 * @param array $opts 24 * @return Response 23 * Gets a subscription or subscribers list from cassandra. 24 * 25 * @param array $opts - 26 * guid - required! 27 * type - either 'subscribers' or 'subscriptions'. 28 * limit - limit. 29 * offset - offset. 30 * @return Response response object. 25 31 */ 26 32 public function getList(array $opts = []) - Owner
: Response
added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label