Entity Centric Manager
Request to merge feat/entity-centric-checkin into master
0/4 threads resolved
changed milestone to %Analytics #mvp
added MR::Awaiting Review scoped label
assigned to @gthouret
1 <?php 2 /** 3 * EntityCentric Repository 4 * @author Mark 5 */ 6 7 namespace Minds\Core\Analytics\EntityCentric; 8 9 use Minds\Core\Analytics\Views\DownsampledView; 
DeveloperClass does not exist
42 43 return $response; 44 } 45 46 /** 47 * @param EntityCentricRecord $record 48 * @return bool 49 * @throws Exception 50 */ 51 public function add(EntityCentricRecord $record) 52 { 53 $index = 'minds-entitycentric-' . date('m-Y', $record->getTimestamp()); 54 55 $body = [ 56 'resolution' => $record->getResolution(), 57 '@timestamp' => $record->getTimestamp() * 1000, - Developer
getTimestamp() does not exist, get TimestampMs() does but it's not expecting ms?
1 <?php 2 /** 3 * EntityCentricRecord 4 * @author Mark 5 */ 6 7 namespace Minds\Core\Analytics\EntityCentric; 8 9 use Minds\Traits\MagicAttributes; 10 11 /** 12 * Class EntityCentricRecord 13 * @package Minds\Core\Analytics\Views - Developer
Docblock doesn't match the class name and is missing getSums/setSums
24 { 25 $this->out('Missing subcommand'); 26 } 27 28 public function sync() 29 { 30 error_reporting(E_ALL); 31 ini_set('display_errors', 1); 32 33 $daysAgo = $this->getOpt('daysAgo') ?: 0; 34 $from = $this->getOpt('from') ?: strtotime("midnight $daysAgo days ago"); 35 $manager = new Manager(); 36 $manager->setFrom($from); 37 38 $i = 0; 39 foreach ($manager->sync() as $record) { - Developer
$manager->sync()is void return where we are expecting array