WIP: [Sprint/NuancedNumbat](fix): Ban email now returning string of ban reason rather than index.
Need to test this on the sandbox. Marking as requires changes until I have.
Closed by 
The changes were not merged into master
added MR::Requires Changes Squad::Yellow scoped labels
added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label
added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label
Resolved by Ben Hayward
Resolved by Ben Haywardadded 1 commit
- c96f482e - Changed location of call and put ban reasons in settings
resolved all threads
added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label
Last updated by Emiliano Balbuena23 30 ->setBody('banned.tpl') 24 31 ->set('username', $user->username) 25 32 ->set('email', $user->getEmail()) 26 ->set('reason', $user->ban_reason) 33 ->set('reason', getBanReasons($user->ban_reason)) - Developer
I think this is a bit more complicated, as I found a few inconsistencies throughout our codebase:
expects indices separated by "." (like reason.subreason)? https://gitlab.com/minds/front/blob/master/src%2Fapp%2Fmodules%2Freport%2Fbanned%2Fbanned.component.ts#L45
This equals the reason label. It later inserts it in
$user->ban_reasonline 67: https://gitlab.com/minds/engine/blob/master/Controllers%2Fapi%2Fv1%2Fadmin%2Fban.php#L60inserts an index here: https://gitlab.com/minds/engine/blob/master/Core%2FSecurity%2FAbuseGuard%2FBan.php#L51
inserts a string here: https://gitlab.com/minds/engine/blob/master/Controllers%2FCli%2FSnapshot.php#L79
- Developer
Missing $this
mentioned in issue #868
added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label
marked as a Work In Progress
added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label
closed