Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 865
    • Issues 865
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 45
    • Merge Requests 45
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !574

Open
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/OwlfashionedOwl](fix): Limit hashtag remind #1927

Closes #1927

Summary

Adds an error if a user tries to submit more than 5 hashtags when reminding a post

Testing

Pick a post, remind, type in "#1 (closed) #2 #3 (closed) #4 (closed) #5 (closed) #6" or something to that effect.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "fix/limit-hashtag-remind-1927" "origin/fix/limit-hashtag-remind-1927"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "fix/limit-hashtag-remind-1927"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/limit-hashtag-remind-1927 into master
The source branch is 17 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #85096916 passed with warnings for 95364d00 on fix/limit-hashtag-remind-1927
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Mark Harding
              Mark Harding
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1927

              Mentions #1 (closed), #3 (closed), #4 (closed), and #5 (closed)

              Deletes source branch

              • Discussion 5
              • Commits 4
              • Pipelines 3
              • Changes 4
              0/5 threads resolved
              • Loading...
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 week ago

                added MR::Awaiting Review Squad::Yellow scoped labels

              • Ben Hayward @benhayward.ben added 1 commit 1 week ago

                added 1 commit

                • 95364d00 - Fixed failing AOT build.

                Compare with previous version

              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 16 minutes ago

                added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 15 minutes ago
                src/app/common/components/error/error.component.ts
                1 import { Component, Input } from '@angular/core';
                2
                3 @Component({
                4 selector: 'minds-error-box',
                • Mark Harding
                  Mark Harding @markeharding · 15 minutes ago
                  Owner

                  Remember to use BEM naming conventions as stated here https://developers.minds.com/docs/guides/frontend/#elements-and-classes. This should be m-error-box

                • Please register or sign in to reply
              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 14 minutes ago
                src/app/common/components/error/error.component.ts
                1 import { Component, Input } from '@angular/core';
                2
                3 @Component({
                4 selector: 'minds-error-box',
                5 inputs: ['errorString'],
                6 template: `
                7 <div
                8 class="mdl-card mdl-color--red-500 mdl-color-text--blue-grey-50 mdl-shadow--2dp"
                9 style="min-height:0;"
                10 *ngIf="errorString"
                11 >
                12 <div class="mdl-card__supporting-text mdl-color-text--blue-grey-50">
                • Mark Harding
                  Mark Harding @markeharding · 14 minutes ago
                  Owner

                  Use the new colours, not legacy mdl classes

                • Please register or sign in to reply
              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 14 minutes ago
                src/app/common/components/error/error.component.ts
                1 import { Component, Input } from '@angular/core';
                2
                3 @Component({
                4 selector: 'minds-error-box',
                5 inputs: ['errorString'],
                6 template: `
                7 <div
                8 class="mdl-card mdl-color--red-500 mdl-color-text--blue-grey-50 mdl-shadow--2dp"
                9 style="min-height:0;"
                • Mark Harding
                  Mark Harding @markeharding · 14 minutes ago
                  Owner

                  style?

                • Please register or sign in to reply
              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 14 minutes ago
                src/app/common/components/error/error.component.ts
                1 import { Component, Input } from '@angular/core';
                2
                3 @Component({
                4 selector: 'minds-error-box',
                5 inputs: ['errorString'],
                • Mark Harding
                  Mark Harding @markeharding · 14 minutes ago
                  Owner

                  Should be set via @Input and also message would be better

                • Please register or sign in to reply
              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 13 minutes ago
                src/app/common/components/error/error.component.ts
                3 @Component({
                4 selector: 'minds-error-box',
                5 inputs: ['errorString'],
                6 template: `
                7 <div
                8 class="mdl-card mdl-color--red-500 mdl-color-text--blue-grey-50 mdl-shadow--2dp"
                9 style="min-height:0;"
                10 *ngIf="errorString"
                11 >
                12 <div class="mdl-card__supporting-text mdl-color-text--blue-grey-50">
                13 {{ errorString }}
                14 </div>
                15 </div>
                16 `,
                17 })
                18 export class ErrorBox {
                • Mark Harding
                  Mark Harding @markeharding · 13 minutes ago
                  Owner

                  ErrorBoxComponent

                • Please register or sign in to reply
              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Requires Changes Squad::Yellow
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Emiliano Balbuena
              user avatar
              Brian Hatchet
              user avatar
              Martin Santangelo
              user avatar
              Mark Harding
              user avatar
              Juan Manuel Solaro
              user avatar
              Guy Thouret
              user avatar
              Marcelo Rivera
              Reference: minds/front!574