Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 192
    • Issues 192
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 15
    • Merge Requests 15
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !387

Open
Opened 12 minutes ago by Martin Santangelo@msantang78
  • Report abuse
Report abuse

WIP: Permissions implemented in ActivityActionsheet and ChannelActions

I have also optimized the activity action sheet to check the permissions only when the menu is opened. It was running the check every time the activity was rendered

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "feat/permissions-implementation-model-activitysheet-channels" "origin/feat/permissions-implementation-model-activitysheet-channels"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/release/3.11.0"
git merge --no-ff "feat/permissions-implementation-model-activitysheet-channels"

Step 4. Push the result of the merge to GitLab

git push origin "release/3.11.0"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/permissions-implementation-model-activitysheet-channels into release/3.11.0
Open in Web IDE
  • Email patches
  • Plain diff
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
Requires 2 more approvals.
This is a Work in Progress
You can merge this merge request manually using the
  • Discussion 0
  • Commits 2
  • Pipelines 1
  • Changes 6
  • Loading...
  • Martin Santangelo @msantang78 added Sprint::09/25 - Oldfashioned Owl Squad::Green scoped labels 12 minutes ago

    added Sprint::09/25 - Oldfashioned Owl Squad::Green scoped labels

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
None
Assign to
None
Milestone
None
Assign milestone
None
Time tracking
No estimate or time spent
2
Labels
Sprint::09/25 - Oldfashioned Owl Squad::Green
Assign labels
  • View project labels
Lock merge request
Unlocked
1
1 participant
user avatar
Martin Santangelo
Reference: minds/mobile-native!387