Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 234
    • Issues 234
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 34
    • Merge Requests 34
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !334

Open
Opened 2 weeks ago by Guy Thouret@gthouret
  • Report abuse
Report abuse

Framework Performance Optimisations

Optimised autoloader and framework setup Fixes #845 (closed)

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "feat/845-performance" "origin/feat/845-performance"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "feat/845-performance"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/845-performance into master
The source branch is 42 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #83066189 passed for 27d65ab3 on feat/845-performance
          Requires 2 more approvals from Devs and Deployers.
          Mark Harding
          Mark Harding
          Ben Hayward
          Ben Hayward
          Emiliano Balbuena
          Emiliano Balbuena
          Martin Santangelo
          Martin Santangelo
          Rami Albatal
          Rami Albatal
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #845 (closed)

          • Discussion 3
          • Commits 5
          • Pipelines 1
          • Changes 24
          0/1 thread resolved
          • Loading...
          • Guy Thouret @gthouret added MR::Awaiting Review Product::Platform Sprint::09/11 - Nuanced Numbat Squad::Blue Type::Feature scoped labels 2 weeks ago

            added MR::Awaiting Review Product::Platform Sprint::09/11 - Nuanced Numbat Squad::Blue Type::Feature scoped labels

          • Guy Thouret
            Guy Thouret @gthouret · 2 weeks ago
            Developer

            Devtools output of request latencies for the same page - right hand trace is optimised setup.

            Screenshot_2019-09-19_at_01.16.27

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 12 minutes ago
            Core/Blogs/Events.php
            8 8
            9 9 class Events
            10 10 {
            11 /** @var Legacy\Entity */
            12 protected $legacyEntity;
            13
            14 /** @var Manager */
            15 protected $manager;
            16
            17 11 /** @var EventsDispatcher */
            18 12 protected $eventsDispatcher;
            19 13
            20 public function __construct($legacyEntity = null, $manager = null, $eventsDispatcher = null)
            14 public function __construct($eventsDispatcher = null)
            21 15 {
            22 $this->legacyEntity = $legacyEntity ?: new Legacy\Entity();
            • Mark Harding
              Mark Harding @markeharding · 12 minutes ago
              Owner

              are we not now losing the ability to spec test these events by making this change?

            • Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding · 10 minutes ago
            Owner

            is composer.phar supposed to be committed?

            Edited by Mark Harding 10 minutes ago
          • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 8 minutes ago

            added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          5
          Labels
          MR::Requires Changes Product::Platform Sprint::09/11 - Nuanced Numbat Squad::Blue Type::Feature
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          8
          8 participants
          user avatar
          Mark Harding
          user avatar
          Ben Hayward
          user avatar
          Emiliano Balbuena
          user avatar
          Martin Santangelo
          user avatar
          Rami Albatal
          user avatar
          Marcelo Rivera
          user avatar
          Brian Hatchet
          Reference: minds/engine!334