Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 228
    • Issues 228
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 34
    • Merge Requests 34
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !348

Merged
Opened 1 day ago by Guy Thouret@gthouret
  • Report abuse
Report abuse

(fix) Call to a member function getSubtype() on null in PropagateProperties

Add extra checks for if getSubtype is callable on an entity and if no attachment present to propagate to

Related to #904 (closed)

Edited 1 day ago by Xander Miller
Request to merge fix/904-propagate-bug into master
  • Email patches
  • Plain diff
Pipeline #85507645 passed for af333649 on fix/904-propagate-bug
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Olivia Madrid
          Olivia Madrid
          Martin Santangelo
          Martin Santangelo
          Emiliano Balbuena
          Emiliano Balbuena
          Ben Hayward
          Ben Hayward
          Rami Albatal
          Rami Albatal

          Merged by Xander Miller 12 minutes ago

          The changes were merged into master with 4f21baaa

          The source branch has been deleted

          Closed #904 (closed)

          Pipeline #85855793 failed for 4f21baaa on master
                        • Discussion 1
                        • Commits 1
                        • Pipelines 1
                        • Changes 2
                        • Loading...
                        • Guy Thouret @gthouret added MR::Awaiting Review Priority::1 - High Product::Platform Sprint::09/25 - Oldfashioned Owl Squad::Blue scoped labels 1 day ago

                          added MR::Awaiting Review Priority::1 - High Product::Platform Sprint::09/25 - Oldfashioned Owl Squad::Blue scoped labels

                        • Mark Harding @markeharding added MR::Ready to Merge scoped label and automatically removed MR::Awaiting Review label 1 day ago

                          added MR::Ready to Merge scoped label and automatically removed MR::Awaiting Review label

                        • Xander Miller @xander-miller changed the description 1 day ago

                          changed the description

                        • Xander Miller
                          Xander Miller @xander-miller · 1 day ago
                          Developer

                          @gthouret please edit the issue #904 (closed) and provide instructions on how to recreate. I can't verify the issue is resolve if it is unclear what the issue is. Also I can see it's a simple change but if possible please write a simple spec test for this.

                        • Xander Miller @xander-miller approved this merge request 1 day ago

                          approved this merge request

                        • Mark Harding @markeharding approved this merge request 1 day ago

                          approved this merge request

                        • Xander Miller @xander-miller unapproved this merge request 5 hours ago

                          unapproved this merge request

                        • Mark Harding @markeharding unapproved this merge request 5 hours ago

                          unapproved this merge request

                        • Mark Harding @markeharding approved this merge request 5 hours ago

                          approved this merge request

                        • Xander Miller @xander-miller merged 12 minutes ago

                          merged

                        • Xander Miller @xander-miller mentioned in commit 4f21baaa 12 minutes ago

                          mentioned in commit 4f21baaa

                        • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                        Please register or sign in to reply
                        0 Assignees
                        None
                        Assign to
                        None
                        Milestone
                        None
                        Assign milestone
                        None
                        Time tracking
                        No estimate or time spent
                        5
                        Labels
                        MR::Ready to Merge Priority::1 - High Product::Platform Sprint::09/25 - Oldfashioned Owl Squad::Blue
                        Assign labels
                        • View project labels
                        Lock merge request
                        Unlocked
                        10
                        10 participants
                        user avatar
                        Olivia Madrid
                        user avatar
                        Martin Santangelo
                        user avatar
                        Emiliano Balbuena
                        user avatar
                        Ben Hayward
                        user avatar
                        Rami Albatal
                        user avatar
                        Marcelo Rivera
                        user avatar
                        Brian Hatchet
                        Reference: minds/engine!348

                        Revert this merge request

                        This will create a new commit in order to revert the existing changes.

                        Switch branch
                        Cancel
                        A new branch will be created in your fork and a new merge request will be started.

                        Cherry-pick this merge request

                        Switch branch
                        Cancel
                        A new branch will be created in your fork and a new merge request will be started.