Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 850
    • Issues 850
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 45
    • Merge Requests 45
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !576

Merged
Opened 3 hours ago by Emiliano Balbuena@edgebal
  • Report abuse
Report abuse

(fix): Correctly pass comment entity to media modal

Closes #2003 (closed)

Request to merge hotfix/comments-att-modal into master
  • Email patches
  • Plain diff
Pipeline #85510044 passed with warnings for 0bb1bbf6 on hotfix/comments-att-modal
              Merge request approved. Approved by
              Marcelo Rivera
              Marcelo Rivera
              Xander Miller
              Xander Miller
              Brian Hatchet
              Brian Hatchet
              Mark Harding
              Mark Harding

              Merged by Xander Miller 1 hour ago

              The changes were merged into master with 6b503c18

              The source branch has been deleted

              Closed #2003 (closed)

              Pipeline #85549397 failed for 6b503c18 on master
                            • Discussion 2
                            • Commits 1
                            • Pipelines 1
                            • Changes 3
                            • Loading...
                            • Emiliano Balbuena @edgebal added Product::Platform Squad::Yellow scoped labels 3 hours ago

                              added Product::Platform Squad::Yellow scoped labels

                            • Mark Harding @markeharding approved this merge request 3 hours ago

                              approved this merge request

                            • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 3 hours ago

                              approved this merge request

                            • Mark Harding
                              Mark Harding @markeharding · 3 hours ago
                              Owner

                              Make sure you set Minds.features['media-modal'] = true; in the console first.

                            • Xander Miller
                              Xander Miller @xander-miller · 2 hours ago
                              Developer

                              I'm getting some console errors testing this but I think they are unrelated to this fix.

                              hotfix-comments-att-modal.minds.io_cosole_bugs.har

                            • Xander Miller @xander-miller approved this merge request 2 hours ago

                              approved this merge request

                            • Marcelo Rivera @eiennohi approved this merge request 2 hours ago

                              approved this merge request

                            • Mark Harding @markeharding added MR::Ready to Merge scoped label 1 hour ago

                              added MR::Ready to Merge scoped label

                            • Xander Miller @xander-miller mentioned in commit 6b503c18 1 hour ago

                              mentioned in commit 6b503c18

                            • Xander Miller @xander-miller merged 1 hour ago

                              merged

                            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                            Please register or sign in to reply
                            Assignee
                            Emiliano Balbuena's avatar
                            Emiliano Balbuena @edgebal
                            Assign to
                            None
                            Milestone
                            None
                            Assign milestone
                            None
                            Time tracking
                            No estimate or time spent
                            3
                            Labels
                            MR::Ready to Merge Product::Platform Squad::Yellow
                            Assign labels
                            • View project labels
                            Lock merge request
                            Unlocked
                            10
                            10 participants
                            user avatar
                            Guy Thouret
                            user avatar
                            Ben Hayward
                            user avatar
                            Olivia Madrid
                            user avatar
                            Martin Santangelo
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Emiliano Balbuena
                            user avatar
                            Xander Miller
                            Reference: minds/front!576

                            Revert this merge request

                            This will create a new commit in order to revert the existing changes.

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.

                            Cherry-pick this merge request

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.