(fix): check visibility needs to be bound

src/app/modules/legacy/components/cards/activity/activity-analytics-on-view.service.ts

@@ -61,10 +61,9 @@ export class ActivityAnalyticsOnViewService implements OnDestroy {
  }
  });
 
- this.scroll$ = this.scroll.listenForView().subscribe(this.checkVisibility);
-
- // Do a check for the initial posts
- this.checkVisibility();
+ this.scroll$ = this.scroll.listenForView().subscribe(() => {
+ this.checkVisibility();
+ });
  }
 
  checkVisibility() {

src/app/modules/legacy/components/cards/activity/activity.ts

@@ -239,6 +239,8 @@ export class Activity implements OnInit {
  this.activity.time_created || Math.floor(Date.now() / 1000);
 
  this.allowComments = this.activity.allow_comments;
+
+ this.activityAnalyticsOnViewService.checkVisibility(); // perform check
  }
 
  getOwnerIconTime() {

src/app/modules/media/view/view.component.ts

@@ -86,12 +86,6 @@ export class MediaViewComponent implements OnInit, OnDestroy {
  }
  }
  );
-
- this.analyticsService.recordView(this.entity, {
- position: -1,
- source: 'single',
- medium: 'single',
- });
  }
 
  ngOnDestroy() {
@@ -133,6 +127,8 @@ export class MediaViewComponent implements OnInit, OnDestroy {
  }
  }
 
+ this.recordAnalytics();
+
  this.detectChanges();
  })
  .catch(e => {
@@ -224,6 +220,14 @@ export class MediaViewComponent implements OnInit, OnDestroy {
  return this.entity['comments:count'] >= 1;
  }
 
+ recordAnalytics() {
+ this.analyticsService.recordView(this.entity, {
+ position: -1,
+ source: 'single',
+ medium: 'single',
+ });
+ }
+
  private detectChanges() {
  this.cd.markForCheck();
  this.cd.detectChanges();

src/app/services/analytics.ts

@@ -73,6 +73,9 @@ export class AnalyticsService {
  medium: string;
  }
  ) {
- await this.client.post('api/v2/analytics/entity/' + entity.guid, meta);
+ await this.client.post(
+ 'api/v2/analytics/views/entity/' + entity.guid,
+ meta
+ );
  }
 }