Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 151
    • Issues 151
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 7
    • Merge Requests 7
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !372

Our Privacy Policy has changed, please visit https://about.gitlab.com/privacy to review these changes.

Merged
Opened 18 hours ago by Martin Santangelo@msantang78
  • Report abuse
Report abuse

(fix) comment navigation to group should open conversation tab and autoscroll error on unmounted component

closes #1363 (closed) closes #1364 (closed)

Edited 17 hours ago by Martin Santangelo

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "fix/comment-notification-navigation-groups" "origin/fix/comment-notification-navigation-groups"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "fix/comment-notification-navigation-groups"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/comment-notification-navigation-groups into master
  • Email patches
  • Plain diff
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
Merge request approved. Approved by
Juan Manuel Solaro
Juan Manuel Solaro
Marcelo Rivera
Marcelo Rivera

Merged by Martin Santangelo 37 minutes ago

The changes were merged into master with ce22e957

Closed #1363 (closed) and #1364 (closed)

Pipeline #84978454 passed for ce22e957 on master
      • Discussion 0
      • Commits 2
      • Pipelines 2
      • Changes 2
      • Loading...
      • Martin Santangelo @msantang78 changed milestone to %Mobile 3.10 18 hours ago

        changed milestone to %Mobile 3.10

      • Martin Santangelo @msantang78 added MR::Awaiting Review Sprint::09/25 - Oldfashioned Owl Squad::Green scoped labels 18 hours ago

        added MR::Awaiting Review Sprint::09/25 - Oldfashioned Owl Squad::Green scoped labels

      • Martin Santangelo @msantang78 added 1 commit 17 hours ago

        added 1 commit

        • 102c8fdc - (fix) autoscroll after component is unmounted

        Compare with previous version

      • Martin Santangelo @msantang78 changed title from (fix) comment navigation to group should open conversation tab and navigate to the message to (fix) comment navigation to group should open conversation tab and autoscroll error on unmounted component 17 hours ago

        changed title from (fix) comment navigation to group should open conversation tab and navigate to the message to (fix) comment navigation to group should open conversation tab and autoscroll error on unmounted component

      • Martin Santangelo @msantang78 changed the description 17 hours ago

        changed the description

      • Marcelo Rivera @eiennohi approved this merge request 49 minutes ago

        approved this merge request

      • Juan Manuel Solaro @juanmsolaro approved this merge request 41 minutes ago

        approved this merge request

      • Martin Santangelo @msantang78 mentioned in commit ce22e957 37 minutes ago

        mentioned in commit ce22e957

      • Martin Santangelo @msantang78 merged 37 minutes ago

        merged

      • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
      Please register or sign in to reply
      0 Assignees
      None
      Assign to
      Mobile 3.10
      Milestone
      Mobile 3.10
      Assign milestone
      None
      Time tracking
      No estimate or time spent
      3
      Labels
      MR::Awaiting Review Sprint::09/25 - Oldfashioned Owl Squad::Green
      Assign labels
      • View project labels
      Lock merge request
      Unlocked
      3
      3 participants
      user avatar
      Martin Santangelo
      user avatar
      Juan Manuel Solaro
      user avatar
      Marcelo Rivera
      Reference: minds/mobile-native!372

      Revert this merge request

      This will create a new commit in order to revert the existing changes.

      Switch branch
      Cancel
      A new branch will be created in your fork and a new merge request will be started.

      Cherry-pick this merge request

      Switch branch
      Cancel
      A new branch will be created in your fork and a new merge request will be started.