Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 222
    • Issues 222
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 41
    • Merge Requests 41
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !347

Our Privacy Policy has changed, please visit https://about.gitlab.com/privacy to review these changes.

Open
Opened 13 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/OldfashionedOwl](fix): Subscription feed upgrade #435

Closes #435

Summary

This page was using some very old code, so I've upgraded it to use the paging tokens. This should avoid situations like this: https://www.minds.com/kratommotivation1/subscriptions

Testing

To test, pick a user with some subscriptions, and visit /{user}/subscriptions.

Click through subscriptions and subscribers, scroll up and down. https://fix-subscription-feed-435.minds.io/

For bonus points, deploy against live data and check: https://www.minds.com/kratommotivation1/subscriptions

Edited 11 hours ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "fix/subscription-feed-435" "origin/fix/subscription-feed-435"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "fix/subscription-feed-435"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/subscription-feed-435 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #84839674 failed for 0f12af4c on fix/subscription-feed-435
          Requires 3 more approvals from Devs, Deployers, and QA.
          Guy Thouret
          Guy Thouret
          Martin Santangelo
          Martin Santangelo
          Emiliano Balbuena
          Emiliano Balbuena
          Rami Albatal
          Rami Albatal
          Mark Harding
          Mark Harding
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #435

          Deletes source branch

          • Discussion 0
          • Commits 2
          • Pipelines 2
          • Changes 5
          • Loading...
          • Ben Hayward @benhayward.ben added Squad::Yellow scoped label 13 hours ago

            added Squad::Yellow scoped label

          • Ben Hayward @benhayward.ben added 1 commit 11 hours ago

            added 1 commit

            • 0f12af4c - Updated

            Compare with previous version

          • Ben Hayward @benhayward.ben unmarked as a Work In Progress 11 hours ago

            unmarked as a Work In Progress

          • Ben Hayward @benhayward.ben changed the description 11 hours ago

            changed the description

          • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label 11 hours ago

            added MR::Awaiting Review scoped label

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Awaiting Review Squad::Yellow
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Guy Thouret
          user avatar
          Martin Santangelo
          user avatar
          Emiliano Balbuena
          user avatar
          Rami Albatal
          user avatar
          Mark Harding
          user avatar
          Marcelo Rivera
          user avatar
          Olivia Madrid
          Reference: minds/engine!347