Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 831
    • Issues 831
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 48
    • Merge Requests 48
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !436

Our Privacy Policy has changed, please visit https://about.gitlab.com/privacy to review these changes.

Closed
Opened 2 months ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/InterestingIguana](feat) Show error on hashtag limit when editing post #867

Closes #867 (closed)

Make a post with 5 hashtags, try to edit in a sixth.

Edited 2 months ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "fix/hashtag-limit-edit-867" "origin/fix/hashtag-limit-edit-867"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "fix/hashtag-limit-edit-867"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/hashtag-limit-edit-867 into master
  • Email patches
  • Plain diff
Pipeline #84181680 passed for 16e6582e on fix/hashtag-limit-edit-867
              Requires 2 more approvals from Devs and Deployers.
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Mark Harding
              Mark Harding
              Marcelo Rivera
              Marcelo Rivera
              Martin Santangelo
              Martin Santangelo

              Closed by Ben Hayward 10 minutes ago

              The changes were not merged into master

              Did not close #867 (closed)

              Deletes source branch

              • Discussion 4
              • Commits 7
              • Pipelines 9
              • Changes 7
              2/2 threads resolved
              • Loading...
              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 months ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet unapproved this merge request 2 months ago

                unapproved this merge request

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet started a thread on an old version of the diff 2 months ago
                Resolved by Ben Hayward 2 months ago
              • Ben Hayward @benhayward.ben added 1 commit 2 months ago

                added 1 commit

                • dde8fef4 - Updated hashtag error to show on editing too many hashtags

                Compare with previous version

              • Ben Hayward @benhayward.ben resolved all threads 2 months ago

                resolved all threads

              • Ben Hayward
                Ben Hayward @benhayward.ben · 2 months ago
                Developer

                Thanks @brianhatchet, appears I missed committing a couple of files

              • Ben Hayward @benhayward.ben changed milestone to %sprint: Interesting Iguana 2 months ago

                changed milestone to %sprint: Interesting Iguana

              • Ben Hayward @benhayward.ben mentioned in issue #1457 (closed) 2 months ago

                mentioned in issue #1457 (closed)

              • Ben Hayward
                Ben Hayward @benhayward.ben · 2 months ago
                Developer

                Need to add remind, editing remind works fine, but the remind poster still allows you to have more than 5

              • Ben Hayward @benhayward.ben marked as a Work In Progress 2 months ago

                marked as a Work In Progress

              • Ben Hayward @benhayward.ben changed the description 2 months ago

                changed the description

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 months ago

                approved this merge request

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 2 months ago
                Resolved by Ben Hayward 2 months ago
              • Ben Hayward @benhayward.ben added 50 commits 2 months ago

                added 50 commits

                • dde8fef4...3fad9777 - 48 commits from branch master
                • d69432cc - Merge branch 'master' of gitlab.com:minds/front into fix/hashtag-limit-edit-867
                • dad30b76 - Added for remind component and tidied

                Compare with previous version

              • Ben Hayward @benhayward.ben added 1 commit 2 months ago

                added 1 commit

                • 5522bf43 - Update src/app/modules/legacy/components/cards/remind/remind.ts,...

                Compare with previous version

              • Ben Hayward @benhayward.ben unmarked as a Work In Progress 2 months ago

                unmarked as a Work In Progress

              • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label 2 months ago

                added MR::Awaiting Review scoped label

              • Ben Hayward @benhayward.ben resolved all threads 2 months ago

                resolved all threads

              • Mark Harding @markeharding added Squad::Green scoped label 2 months ago

                added Squad::Green scoped label

              • Marcelo Rivera @eiennohi approved this merge request 2 months ago

                approved this merge request

              • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

                added 1 commit

                • 663e6953 - Updated conflicts

                Compare with previous version

              • Ben Hayward @benhayward.ben added 192 commits 2 weeks ago

                added 192 commits

                • 663e6953...1c8ddd09 - 190 commits from branch master
                • 26a48b49 - Merge branch 'master' of gitlab.com:minds/front into fix/hashtag-limit-edit-867
                • c7394e1a - Updated for conflicts

                Compare with previous version

              • Ben Hayward @benhayward.ben added 2 commits 2 weeks ago

                added 2 commits

                • c4a30fe3 - Updated for conflicts
                • c46eb2a6 - Accidental commit

                Compare with previous version

              • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

                added 1 commit

                • 61be1415 - Lint

                Compare with previous version

              • Ben Hayward @benhayward.ben mentioned in issue #1927 6 days ago

                mentioned in issue #1927

              • Ben Hayward @benhayward.ben added 50 commits 1 day ago

                added 50 commits

                • 61be1415...3ea249c0 - 49 commits from branch master
                • 16e6582e - Merge branch 'master' into 'fix/hashtag-limit-edit-867'

                Compare with previous version

              • Ben Hayward @benhayward.ben closed 10 minutes ago

                closed

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              sprint: Interesting Iguana
              Milestone
              sprint: Interesting Iguana
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Green
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              6
              6 participants
              user avatar
              Emiliano Balbuena
              user avatar
              Brian Hatchet
              user avatar
              Mark Harding
              user avatar
              Marcelo Rivera
              user avatar
              Martin Santangelo
              user avatar
              Ben Hayward
              Reference: minds/front!436