Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 825
    • Issues 825
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 46
    • Merge Requests 46
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !557

Our Privacy Policy has changed, please visit https://about.gitlab.com/privacy to review these changes.

Open
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/NuancedNumbat](fix): Fixed width of avatars.

Closes #1913 (closed)#

Upload an avatar and check it out around the site. Make sure its not warped anywhere. Send a notification to a second test user, make sure your picture shows up okay.

image

ideally I'd deploy this on a network linked into production so that I can test this specific user, as uploading the image he posted, does not emulate the effect of the wide avatar that he has.

Edited 1 week ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "fix/max-avatar-width-1913" "origin/fix/max-avatar-width-1913"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "fix/max-avatar-width-1913"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/max-avatar-width-1913 into master
The source branch is 2 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #83826233 passed for 4691ed22 on fix/max-avatar-width-1913
              Merge request approved. Approved by
              Marcelo Rivera
              Marcelo Rivera
              Emiliano Balbuena
              Emiliano Balbuena
              Olivia Madrid
              Olivia Madrid
              Brian Hatchet
              Brian Hatchet
              Mark Harding
              Mark Harding
              Guy Thouret
              Guy Thouret
              Juan Manuel Solaro
              Juan Manuel Solaro
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1913 (closed)

              Deletes source branch

              • Discussion 2
              • Commits 2
              • Pipelines 2
              • Changes 3
              • Loading...
              • Ben Hayward @benhayward.ben changed the description 1 week ago

                changed the description

              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 week ago

                added MR::Awaiting Review Squad::Yellow scoped labels

              • Ben Hayward @benhayward.ben added 25 commits 2 days ago

                added 25 commits

                • c9ab0fb1...3ea249c0 - 24 commits from branch master
                • 4691ed22 - Merge branch 'master' of gitlab.com:minds/front into fix/max-avatar-width-1913

                Compare with previous version

              • Emiliano Balbuena @edgebal approved this merge request 2 days ago

                approved this merge request

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal · 2 days ago
                Developer

                @markeharding Can we get this on a testable production environment?

              • Marcelo Rivera @eiennohi approved this merge request 3 hours ago

                approved this merge request

              • Ben Hayward
                Ben Hayward @benhayward.ben · 2 hours ago
                Developer

                I cannot see my changes on revolver :thinking:

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Yellow
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Olivia Madrid
              user avatar
              Brian Hatchet
              user avatar
              Mark Harding
              user avatar
              Guy Thouret
              user avatar
              Juan Manuel Solaro
              user avatar
              Martin Santangelo
              user avatar
              Ben Hayward
              Reference: minds/front!557