Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 220
    • Issues 220
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 37
    • Merge Requests 37
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !285

Open
Opened 1 month ago by Guy Thouret@gthouret
  • Report abuse
Report abuse

Reward Factors for User Activity

Edited 1 month ago by Guy Thouret

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "feat/588-state-on-user" "origin/feat/588-state-on-user"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "feat/588-state-on-user"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/588-state-on-user into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #84123242 passed for a88597d7 on feat/588-state-on-user
          Requires 2 more approvals from Devs and Deployers.
          Mark Harding
          Mark Harding
          Ben Hayward
          Ben Hayward
          Marcelo Rivera
          Marcelo Rivera
          Rami Albatal
          Rami Albatal
          Martin Santangelo
          Martin Santangelo
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #810

          • Discussion 10
          • Commits 69
          • Pipelines 33
          • Changes 105
          3/3 threads resolved
          • Loading...
          • Guy Thouret @gthouret changed milestone to %"sprint: Jolly Jellyfish" 1 month ago

            changed milestone to %"sprint: Jolly Jellyfish"

          • Guy Thouret @gthouret added MR::Awaiting Review Priority::2 - Normal Product::Wallet Squad::Blue Type::Feature scoped labels 1 month ago

            added MR::Awaiting Review Priority::2 - Normal Product::Wallet Squad::Blue Type::Feature scoped labels

          • Guy Thouret @gthouret added 2 commits 1 month ago

            added 2 commits

            • 8d2051bc - (fix) Update UserStates Manager test with reward factor fields - #589 (closed)
            • 42e5591b - (feat) Add state change value to UserState object - #588 (closed)

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 1 month ago

            added 1 commit

            • 59e50c27 - (feat) Split state change view to separate views for increasing and decreasing user state - #589 (closed)

            Compare with previous version

          • Guy Thouret @gthouret added 6 commits 1 month ago

            added 6 commits

            • 01b11f8d - (fix) Rewards\Contributions: Fix typo in word contribution - #587 (closed)
            • c036456b - (fix) Spec bootstrap should load configs (prevents errors connecting to Redis and MQ in dev) - #587 (closed)
            • d0425dd2 - (chore) Add missing help descriptions to rewards cli controller - #587 (closed)
            • 444c6081 - (feat) Add missing type hints in Contributions Manager - #588 (closed)
            • f150613d - (feat) Add action types help text and dry run warning to rewards cli - #587 (closed)
            • 18084897 - (feat) Apply the user state reward multiplier to contribution scores - #587 (closed)

            Compare with previous version

            Toggle commit list
          • Guy Thouret @gthouret added 3 commits 1 month ago

            added 3 commits

            • 00beca90 - (fix) Fix expected value in Rewards Manager Spec test
            • 9c166d03 - (chore) Add missing command help and dry run option to contributions cli - #587 (closed)
            • 3b80c207 - (feat) Add decimal score value to contributions table - #587 (closed)

            Compare with previous version

          • Guy Thouret @gthouret added 2 commits 1 month ago

            added 2 commits

            • c11424f2 - (fix) Record null value for old contributions score by omitting from INSERT query - #587 (closed)
            • d7f0d443 - (feat) Add current reward factor to contributions api - #661 (closed)

            Compare with previous version

          • Guy Thouret @gthouret added 3 commits 1 month ago

            added 3 commits

            • 167c20ef - (fix) Notification view for user state should be plural rewards_* - #589 (closed)
            • d8348319 - (fix) Divide by zero error Contributions\DailyCollection - #587 (closed)
            • 6a760f03 - (fix) Send a notification when a user is rewarded with tokens for contributions - #636 (closed)

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 1 month ago

            added 1 commit

            • fba7d4e7 - (fix) Test regression in UpdateUserState delegate - #588 (closed)

            Compare with previous version

          • Guy Thouret @gthouret unmarked as a Work In Progress 1 month ago

            unmarked as a Work In Progress

          • Guy Thouret
            Guy Thouret @gthouret · 1 month ago
            Developer

            NOTE: Requires schema changes to minds.contributions:

            ALTER TABLE minds.contributions ADD score_decimal decimal;
            DROP MATERIALIZED VIEW minds.contributions_by_timestamp;
            CREATE MATERIALIZED VIEW minds.contributions_by_timestamp AS
                SELECT timestamp, user_guid, metric, amount, score, score_decimal
                FROM minds.contributions
                WHERE user_guid IS NOT NULL AND timestamp IS NOT NULL AND metric IS NOT NULL AND amount IS NOT NULL
                PRIMARY KEY (timestamp, user_guid, metric)
                WITH CLUSTERING ORDER BY (user_guid ASC, metric ASC);
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 1 month ago
            Resolved by Guy Thouret 1 month ago
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 1 month ago
            Resolved by Guy Thouret 1 month ago
          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 1 month ago
            Resolved by Guy Thouret 1 month ago
          • Guy Thouret @gthouret added 1 commit 1 month ago

            added 1 commit

            • 2d9337ef - (chore) Convert a rogue tab in whitespace to spaces

            Compare with previous version

          • Guy Thouret @gthouret resolved all threads 1 month ago

            resolved all threads

          • Guy Thouret @gthouret added 1 commit 1 month ago

            added 1 commit

            • 9268f852 - (chore) Update failing UserStates ManagerSpec with new reward factor value - #588 (closed)

            Compare with previous version

          • Mark Harding @markeharding approved this merge request 3 weeks ago

            approved this merge request

          • Guy Thouret @gthouret added 34 commits 3 weeks ago

            added 34 commits

            • 9268f852...d684846f - 32 commits from branch master
            • cc1b2a2d - (chore) Result of linting branch before merge - #588 (closed)
            • 6458b943 - (chore) Merge linted master to branch - #588 (closed)

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 3 weeks ago

            added 1 commit

            • 8df0dac5 - (chore) More lints that got mised from last commit - #588 (closed)

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 3 weeks ago

            added 1 commit

            • 87e2f5b3 - (chore) Fix test regression after linting - #588 (closed)

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 2 weeks ago

            added 1 commit

            • 0e8d8b00 - (fix) Previously fixed typo made it back into branch - #588 (closed)

            Compare with previous version

          • Guy Thouret @gthouret added 2 commits 2 weeks ago

            added 2 commits

            • 634f63e5 - (chore) Refactor ActiveUsersIterator to extract the query builder from the...
            • 0628b4d2 - (feat) Allow for 'incremental' running of the syncUsers analytics cli to emit...

            Compare with previous version

          • Guy Thouret @gthouret added 3 commits 1 week ago

            added 3 commits

            • 9252c893 - (chore) Fix up broken test and add test for the active users query builder - #590
            • 163b8a2f - (chore) Remove debug code from UpdateUserStateEstimate and simplify notification logic - #590
            • 343a3648 - (chore) Spacing in ActiveUsersIterator - #590

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 1 week ago

            added 1 commit

            • 12ec947c - (chore) Linting recent changes - #590

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 1 week ago

            added 1 commit

            • 1fbb590f - (feat) Add reward factors to v1/blockchain/contributions API endpoint - Fixes #810

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 1 week ago

            added 1 commit

            • 96748a37 - (feat) Return reward factors as objects in v1/blockchain/contributions API endpoint - #810

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 1 week ago

            added 1 commit

            • af3c0bce - (fix) ActiveUsersQueryBuilder Spec test is only successful with a specific base time - #590

            Compare with previous version

          • Guy Thouret @gthouret added 10 commits 1 week ago

            added 10 commits

            • af3c0bce...14f32dc5 - 9 commits from branch master
            • e491df61 - Merge branch 'master' into feat/588-state-on-user

            Compare with previous version

          • Guy Thouret @gthouret added 23 commits 6 days ago

            added 23 commits

            • e491df61...91c223dc - 22 commits from branch master
            • 348c3a46 - Merge branch 'master' into feat/588-state-on-user

            Compare with previous version

          • Guy Thouret @gthouret added 8 commits 16 hours ago

            added 8 commits

            • 4cdd24ee - (feat) Simplify UserActivityBuckets - transition detection to cold is not...
            • 362df68b - (fix) userActivity data is now sorted by date to guarantee correct ordering - #841
            • 46251ea2 - (fix) UserStates - Only allow update of previousState back to ES if it is not empty - #841
            • 9825278b - (feat) Add debug option and fakeactivity command to analyics cli - #841
            • e4159346 - (feat) Add setTimestamp to Event for generating fake activity in the past - #841
            • 1bc69e5d - (fix) Record actual update time in UpdateUserState delegates - #841
            • 41149a48 - (feat) Simplify the ActiveUser and UserState Iterators; Use more meaningful...
            • 01222a57 - (fix) Allow UserState export to exclude fields with null values to prevent...

            Compare with previous version

            Toggle commit list
          • Guy Thouret @gthouret added 3 commits 15 hours ago

            added 3 commits

            • 46a3081d - (fix) Create correct 'active' fake data in analytics cli - #841
            • ed9109ca - (fix) Regression - ActiveUsers query should have 200 partitions - #841
            • 00ffa02e - (fix) Fix all tests for most recent changes to ActiveUsers and UserStates Iterators - #841

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 15 hours ago

            added 1 commit

            • 168ca91b - (fix) Regression in UpdateUserStateSpec - #841

            Compare with previous version

          • Guy Thouret @gthouret added 11 commits 5 hours ago

            added 11 commits

            • 168ca91b...72c7048d - 9 commits from branch master
            • b6aab277 - (feat) Modify analytics cli and active action event so that activity days...
            • 0770cf69 - Merge branch 'master' into feat/588-state-on-user

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 5 hours ago

            added 1 commit

            • 142841ae - (fix) action property of analytics event is not always present

            Compare with previous version

          • Guy Thouret
            Guy Thouret @gthouret · 1 hour ago
            Developer

            QA was carried out on the review site, testing procedure and outputs for achieving all user states are in #841.

          • Guy Thouret
            Guy Thouret @gthouret · 1 hour ago
            Developer

            Transitions are generating the required notifications with the exception of reward_state_decline_today which should not be telling people that they are declining into resurrected.

          • Guy Thouret @gthouret added 1 commit 48 minutes ago

            added 1 commit

            • c6d2641f - (feat) Ignore certain state changes when sending user notifications

            Compare with previous version

          • Guy Thouret @gthouret added 1 commit 24 minutes ago

            added 1 commit

            • a88597d7 - (fix) Update spec test for UpdateUserState delegate as state it used does not...

            Compare with previous version

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          (07/17) Jolly Jellyfish
          Milestone
          (07/17) Jolly Jellyfish
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          5
          Labels
          MR::Awaiting Review Priority::2 - Normal Product::Wallet Squad::Blue Type::Feature
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          8
          8 participants
          user avatar
          Mark Harding
          user avatar
          Ben Hayward
          user avatar
          Marcelo Rivera
          user avatar
          Rami Albatal
          user avatar
          Martin Santangelo
          user avatar
          Emiliano Balbuena
          user avatar
          Brian Hatchet
          Reference: minds/engine!285