Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 220
    • Issues 220
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 36
    • Merge Requests 36
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !333

Closed
Opened 5 days ago by Mark Harding@markeharding
  • Report abuse
Report abuse

WIP: Resolve "Issue referral cookie on channel and asset pages if not already set"

Closes #842

Edited 3 days ago by Mark Harding

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "feat/842-issue-referral-cookie" "origin/feat/842-issue-referral-cookie"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "feat/842-issue-referral-cookie"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/842-issue-referral-cookie into master
  • Email patches
  • Plain diff
Pipeline #83994530 passed for d5890d6d on feat/842-issue-referral-cookie
          Requires 2 more approvals from Devs and Deployers.
          Rami Albatal
          Rami Albatal
          Ben Hayward
          Ben Hayward
          Martin Santangelo
          Martin Santangelo
          Marcelo Rivera
          Marcelo Rivera
          Brian Hatchet
          Brian Hatchet

          Closed by Mark Harding 10 minutes ago

          The changes were not merged into master

          Did not close #842

          • Discussion 0
          • Commits 2
          • Pipelines 9
          • Changes 8
          • Loading...
          • Mark Harding @markeharding changed milestone to %Affiliate #mvp 5 days ago

            changed milestone to %Affiliate #mvp

          • Mark Harding @markeharding added Priority::1 - High Product::Referrals Sprint::09/11 - Nuanced Numbat Squad::Blue Status::InProgress scoped labels 5 days ago

            added Priority::1 - High Product::Referrals Sprint::09/11 - Nuanced Numbat Squad::Blue Status::InProgress scoped labels

          • Mark Harding @markeharding added 1 commit 5 days ago

            added 1 commit

            • 8450551b - (feat): issue cookies to asset owners or channels without referrer param

            Compare with previous version

          • Mark Harding @markeharding added MR::Awaiting Review scoped label 5 days ago

            added MR::Awaiting Review scoped label

          • Mark Harding @markeharding unmarked as a Work In Progress 3 days ago

            unmarked as a Work In Progress

          • Mark Harding @markeharding marked as a Work In Progress 3 days ago

            marked as a Work In Progress

          • Mark Harding @markeharding added 1 commit 3 days ago

            added 1 commit

            • d4be9314 - (fix): move create referral cookie step to shutdown function vs api result

            Compare with previous version

          • Mark Harding @markeharding added 1 commit 3 days ago

            added 1 commit

            • a56d96bb - (fix): move create referral cookie step to shutdown function vs api result

            Compare with previous version

          • Mark Harding @markeharding added 1 commit 3 days ago

            added 1 commit

            • 6c7c6a3d - (fix): move create referral cookie step to shutdown function vs api result

            Compare with previous version

          • Mark Harding @markeharding added 1 commit 3 days ago

            added 1 commit

            • 42b59dca - (fix): move create referral cookie step to shutdown function vs api result

            Compare with previous version

          • Mark Harding @markeharding added 1 commit 3 days ago

            added 1 commit

            • e7087e36 - (fix): move create referral cookie step to shutdown function vs api result

            Compare with previous version

          • Mark Harding @markeharding added 1 commit 3 days ago

            added 1 commit

            • 0309351a - (fix): move create referral cookie step to shutdown function vs api result

            Compare with previous version

          • Mark Harding @markeharding added 1 commit 18 hours ago

            added 1 commit

            • 4ed0025f - (fix): move create referral cookie step to shutdown function vs api result

            Compare with previous version

          • Mark Harding @markeharding added 1 commit 24 minutes ago

            added 1 commit

            • d5890d6d - (fix): call create after each set

            Compare with previous version

          • Mark Harding @markeharding closed 10 minutes ago

            closed

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          Affiliate #mvp
          Milestone
          Affiliate #mvp
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          6
          Labels
          MR::Awaiting Review Priority::1 - High Product::Referrals Sprint::09/11 - Nuanced Numbat Squad::Blue Status::InProgress
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Rami Albatal
          user avatar
          Ben Hayward
          user avatar
          Martin Santangelo
          user avatar
          Marcelo Rivera
          user avatar
          Brian Hatchet
          user avatar
          Emiliano Balbuena
          user avatar
          Mark Harding
          Reference: minds/engine!333