Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 212
    • Issues 212
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 35
    • Merge Requests 35
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !331

Open
Opened 18 minutes ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/NuancedNumbat](fix): Allowing onchain boosts when offchain limit reached #1924

Closes front#1924

Testing

Should test this on a sandbox tied to production data so that we can test with actual onchain tokens.

  1. Hit the offchain boost limit.
  2. Try to make an onchain boost.
Edited 17 minutes ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "fix/onchain-limit-1924" "origin/fix/onchain-limit-1924"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "fix/onchain-limit-1924"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/onchain-limit-1924 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #82789735 passed for 85264176 on fix/onchain-limit-1924
          Requires 2 more approvals from Devs and Deployers.
          Mark Harding
          Mark Harding
          Rami Albatal
          Rami Albatal
          Marcelo Rivera
          Marcelo Rivera
          Brian Hatchet
          Brian Hatchet
          Emiliano Balbuena
          Emiliano Balbuena
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes front#1924

          Deletes source branch

          • Discussion 0
          • Commits 3
          • Pipelines 3
          • Changes 2
          • Loading...
          • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 18 minutes ago

            added MR::Awaiting Review Squad::Yellow scoped labels

          • Ben Hayward @benhayward.ben changed the description 17 minutes ago

            changed the description

          • Ben Hayward @benhayward.ben added 1 commit 12 minutes ago

            added 1 commit

            • 85264176 - Updated test title

            Compare with previous version

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Awaiting Review Squad::Yellow
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Mark Harding
          user avatar
          Rami Albatal
          user avatar
          Marcelo Rivera
          user avatar
          Brian Hatchet
          user avatar
          Emiliano Balbuena
          user avatar
          Martin Santangelo
          user avatar
          Ben Hayward
          Reference: minds/engine!331