Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 836
    • Issues 836
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 43
    • Merge Requests 43
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !494

Open
Opened 1 month ago by Juan Manuel Solaro@juanmsolaro
  • Report abuse
Report abuse

epic/post-scheduler

Edited 7 minutes ago by Juan Manuel Solaro

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "epic/post-scheduler" "origin/epic/post-scheduler"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "epic/post-scheduler"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge epic/post-scheduler into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #82492114 passed with warnings for cfe35f02 on epic/post-scheduler
              Requires 2 more approvals from Devs and Deployers.
              Martin Santangelo
              Martin Santangelo
              Brian Hatchet
              Brian Hatchet
              Olivia Madrid
              Olivia Madrid
              Emiliano Balbuena
              Emiliano Balbuena
              Ben Hayward
              Ben Hayward
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request
              • Discussion 28
              • Commits 41
              • Pipelines 37
              • Changes 27
              22/23 threads resolved
              • Loading...
              • Juan Manuel Solaro @juanmsolaro added 1 commit 1 month ago

                added 1 commit

                • 3d3b9987 - (feat) add tooltip to show date

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 1 month ago

                added 1 commit

                • 79d4c893 - (feat) add custom time when posting, creating and editing blog and when editing activity

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 1 month ago

                added 1 commit

                • 032af961 - (fix) change property name and add mock component to spec tests

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 1 month ago

                added 1 commit

                • 01a4158c - (fix) change format of time created property

                Compare with previous version

              • Emiliano Balbuena
                Emiliano Balbuena @edgebal started a thread on an old version of the diff 1 month ago
                Resolved by Juan Manuel Solaro 4 weeks ago
              • Emiliano Balbuena
                Emiliano Balbuena @edgebal started a thread on an old version of the diff 1 month ago
                Resolved by Juan Manuel Solaro 4 weeks ago
              • Emiliano Balbuena
                Emiliano Balbuena @edgebal started a thread on an old version of the diff 1 month ago
                Resolved by Juan Manuel Solaro 4 weeks ago
              • Emiliano Balbuena
                Emiliano Balbuena @edgebal started a thread on an old version of the diff 1 month ago
                Resolved by Juan Manuel Solaro 4 weeks ago
              • Emiliano Balbuena
                Emiliano Balbuena @edgebal started a thread on an old version of the diff 1 month ago
                Resolved by Juan Manuel Solaro 4 weeks ago
              • Emiliano Balbuena
                Emiliano Balbuena @edgebal started a thread on an old version of the diff 1 month ago
                Resolved by Juan Manuel Solaro 4 weeks ago
              • Emiliano Balbuena
                Emiliano Balbuena @edgebal started a thread on an old version of the diff 1 month ago
                Resolved by Juan Manuel Solaro 4 weeks ago
              • Emiliano Balbuena
                Emiliano Balbuena @edgebal started a thread on an old version of the diff 1 month ago
                Resolved by Juan Manuel Solaro 4 weeks ago
              • Emiliano Balbuena
                Emiliano Balbuena @edgebal started a thread on an old version of the diff 1 month ago
                Resolved by Juan Manuel Solaro 4 weeks ago
              • Emiliano Balbuena
                Emiliano Balbuena @edgebal started a thread on an old version of the diff 1 month ago
                Resolved by Juan Manuel Solaro 4 weeks ago
              • Juan Manuel Solaro @juanmsolaro added 1 commit 4 weeks ago

                added 1 commit

                • ff0c90e4 - (fix) adapt code to reviews

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro resolved all threads 4 weeks ago

                resolved all threads

              • Juan Manuel Solaro @juanmsolaro added 1 commit 3 weeks ago

                added 1 commit

                • 4c47ed6c - (feat) add view and styles for scheduled activities count

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 3 weeks ago

                added 1 commit

                • 8aa592f5 - (feat) filter activities by time_created to get scheduled

                Compare with previous version

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Juan Manuel Solaro 3 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Juan Manuel Solaro 3 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 3 weeks ago
                Last updated by Marcelo Rivera 2 weeks ago
                src/app/modules/blogs/blog.scss
                301 301
                302 302 m-wire-threshold-input {
                303 303 position: relative;
                304 padding: 8px;
                • Mark Harding
                  Mark Harding @markeharding · 3 weeks ago
                  Owner

                  this doesn't look related to post scheduler?

                • Juan Manuel Solaro
                  Juan Manuel Solaro @juanmsolaro · 3 weeks ago
                  Developer

                  I removed that padding because of spacing. We don't have enough when mark Mature Content flag. Screenshot_from_2019-08-22_12-42-50 Another option is to reduce padding from the 'E' icon to from 8px to 6px, like this: Screenshot_from_2019-08-22_12-46-51

                • Marcelo Rivera
                  Marcelo Rivera @eiennohi · 2 weeks ago
                  Developer

                  @markeharding what's your input on this?

                • Please register or sign in to reply
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Juan Manuel Solaro 3 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Juan Manuel Solaro 3 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Juan Manuel Solaro 3 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Juan Manuel Solaro 3 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Juan Manuel Solaro 3 weeks ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                Resolved by Juan Manuel Solaro 3 weeks ago
              • Juan Manuel Solaro @juanmsolaro added 1 commit 3 weeks ago

                added 1 commit

                • 3fa631c7 - (fix) minor view fixes

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 3 weeks ago

                added 1 commit

                • 56dfa91a - (feat) ability to count scheduled activities

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 3 weeks ago

                added 1 commit

                • 8741ca7a - (test) add spec to poster date selector component

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 3 weeks ago

                added 1 commit

                • 1a8b1ef8 - (fix) adapt and fix code to mark's review

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 3 weeks ago

                added 1 commit

                • ac65702a - (fix) move scheduled endpoint as per review

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 3 weeks ago

                added 1 commit

                • b3966e9f - (feat) e2e tests for scheduled activities

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 67 commits 2 weeks ago

                added 67 commits

                • b3966e9f...5ed6e576 - 66 commits from branch master
                • 0c67461b - (fix) merge master to branch

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 4 commits 2 weeks ago

                added 4 commits

                • 0c67461b...9f4057ca - 3 commits from branch master
                • 678daba4 - Merge branch 'master' into epic/post-scheduler

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 2 weeks ago

                added 1 commit

                • 5914b929 - (fix) apply prettier fixes

                Compare with previous version

              • Emiliano Balbuena @edgebal added 6 commits 2 weeks ago

                added 6 commits

                • 5914b929...d69d2bd0 - 4 commits from branch master
                • fea27a60 - (chore): Lint w/ prettierrc
                • de6bc61c - Merge remote-tracking branch 'origin/master' into epic/post-scheduler

                Compare with previous version

              • Marcelo Rivera
                Marcelo Rivera @eiennohi started a thread on an old version of the diff 2 weeks ago
                Resolved by Juan Manuel Solaro 1 week ago
              • Marcelo Rivera
                Marcelo Rivera @eiennohi started a thread on an old version of the diff 2 weeks ago
                Resolved by Juan Manuel Solaro 1 week ago
              • Juan Manuel Solaro @juanmsolaro added 1 commit 2 weeks ago

                added 1 commit

                • f3b32b5c - (feat) date selector should validate date and adapt code as per review

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 2 weeks ago

                added 1 commit

                • 52a199f0 - (fix) apply prettier fixes

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 2 weeks ago

                added 1 commit

                • ab9e5db0 - (fix) update scheduler tests

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 11 commits 2 weeks ago

                added 11 commits

                • ab9e5db0...3d286cd9 - 9 commits from branch master
                • 0e912171 - Merge branch 'master' into epic/post-scheduler
                • 3c91b605 - (fix) notification specs should work correctyly after prettier broke them.

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 2 weeks ago

                added 1 commit

                • c78d27ff - (fix) apply prettier fixes

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 1 week ago

                added 1 commit

                • 87a46b50 - (fix): change datetime picker's min-height for mobile web

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 1 week ago

                added 1 commit

                • 15fec4f5 - (fix) show scheduled banner to just posted activities

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 2 commits 1 week ago

                added 2 commits

                • 7a585236 - (fix) minor fixes and ability of persisting date for datetimepicker.directive
                • 334fac5d - (fix) apply prettier changes

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 1 week ago

                added 1 commit

                • ff893b0f - (fix) datetimepicker overlay should cover all screen

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 1 week ago

                added 1 commit

                • fe3fcb81 - (fix) add new e2e test and change message for poster

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 1 week ago

                added 1 commit

                • 7816c046 - (fix) change spec message for selector.component

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 3 commits 1 week ago

                added 3 commits

                • 48b922aa - (fix) when editing a not scheduled post, scheduler shouldn't be selected
                • 429780b7 - (fix) disable scheduler for blogs that are already published
                • 91cfb06f - (fix) apply prettier fixes

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 1 week ago

                added 1 commit

                • 418f799b - (fix) introduce method to check time_published

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 6 days ago

                added 1 commit

                • 970f99c2 - (fix) scheduled filter should not appear if not owner

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 23 commits 6 days ago

                added 23 commits

                • 970f99c2...2be70043 - 22 commits from branch master
                • 366b3112 - merge master into branch

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 1 commit 5 days ago

                added 1 commit

                • da0917aa - (chore): Disable post scheduler when editing old posts

                Compare with previous version

                • Mark Harding
                  Mark Harding @markeharding · 3 days ago
                  Owner
                  Resolved by Juan Manuel Solaro 6 minutes ago

                  Full Screen macbook pro (13inch) Screen_Shot_2019-09-13_at_2.45.30_PM

                • Juan Manuel Solaro
                  Juan Manuel Solaro
                  Last reply by Juan Manuel Solaro 6 minutes ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 days ago
                Resolved by Juan Manuel Solaro 6 minutes ago
              • Mark Harding @markeharding added MR::Requires Changes Product::Newsfeed Squad::Yellow scoped labels 3 days ago

                added MR::Requires Changes Product::Newsfeed Squad::Yellow scoped labels

              • Juan Manuel Solaro @juanmsolaro added 1 commit 2 hours ago

                added 1 commit

                • 6651141f - (fix): apply changes as per review

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro added 40 commits 2 hours ago

                added 40 commits

                • 6651141f...5018532b - 39 commits from branch master
                • cfe35f02 - Merge master into branch

                Compare with previous version

              • Juan Manuel Solaro @juanmsolaro unmarked as a Work In Progress 7 minutes ago

                unmarked as a Work In Progress

              • Juan Manuel Solaro @juanmsolaro removed MR::Requires Changes label 5 minutes ago

                removed MR::Requires Changes label

              • Juan Manuel Solaro @juanmsolaro added MR::Awaiting Review scoped label 5 minutes ago

                added MR::Awaiting Review scoped label

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              3
              Labels
              MR::Awaiting Review Product::Newsfeed Squad::Yellow
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Martin Santangelo
              user avatar
              Brian Hatchet
              user avatar
              Olivia Madrid
              user avatar
              Emiliano Balbuena
              user avatar
              Ben Hayward
              user avatar
              Marcelo Rivera
              user avatar
              Guy Thouret
              Reference: minds/front!494