Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 837
    • Issues 837
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 43
    • Merge Requests 43
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !555

Open
Opened 32 minutes ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

WIP: [Sprint/NuancedNumbat](fix): e2e test fixes

Boost Impressions: Updated to check correct endpoint and work more efficiently

Awaiting #1912 before we can progress as we need to make the test base stable.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "fix/e2e-test-update-1910" "origin/fix/e2e-test-update-1910"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "fix/e2e-test-update-1910"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/e2e-test-update-1910 into master
The source branch is 10 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #82493441 running for 02d0c2b7 on fix/e2e-test-update-1910
              Requires 2 more approvals from Devs and Deployers.
              Juan Manuel Solaro
              Juan Manuel Solaro
              Martin Santangelo
              Martin Santangelo
              Brian Hatchet
              Brian Hatchet
              Olivia Madrid
              Olivia Madrid
              Emiliano Balbuena
              Emiliano Balbuena
              This is a Work in Progress

              Mentions #1912

              Deletes source branch

              You can merge this merge request manually using the
              • Discussion 0
              • Commits 1
              • Pipelines 1
              • Changes 1
              • Loading...
              • Ben Hayward @benhayward.ben added MR::Requires Changes Squad::Yellow scoped labels 32 minutes ago

                added MR::Requires Changes Squad::Yellow scoped labels

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Requires Changes Squad::Yellow
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Juan Manuel Solaro
              user avatar
              Martin Santangelo
              user avatar
              Brian Hatchet
              user avatar
              Olivia Madrid
              user avatar
              Emiliano Balbuena
              user avatar
              Marcelo Rivera
              user avatar
              Guy Thouret
              Reference: minds/front!555