Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 840
    • Issues 840
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 43
    • Merge Requests 43
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !433

Open
Opened 2 months ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/InterestingIguana](feat): Preferred hashtag remembered in local storage #1366

Closes #1302 (closed)

Test that your selection for preferred is remembered in local storage.

  1. Set it to on
  2. Tab over to wallet or another page
  3. Refresh
  4. Visit discovery - it should have remembered the state was on.
  5. Turn it off, and repeat to confirm that is remembers the 'off' state
Edited 2 weeks ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "fix/default-preferred-state-1366" "origin/fix/default-preferred-state-1366"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "fix/default-preferred-state-1366"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/default-preferred-state-1366 into master
The source branch is 68 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #79257069 passed with warnings for 33831f05 on fix/default-preferred-state-1366
              Requires 2 more approvals from Devs and Deployers.
              Martin Santangelo
              Martin Santangelo
              Brian Hatchet
              Brian Hatchet
              Emiliano Balbuena
              Emiliano Balbuena
              Marcelo Rivera
              Marcelo Rivera
              Mark Harding
              Mark Harding
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1302 (closed)

              Mentions #1366 (closed)

              Deletes source branch

              • Discussion 5
              • Commits 5
              • Pipelines 5
              • Changes 1
              1/1 thread resolved
              • Loading...
              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 months ago

                approved this merge request

              • Mark Harding
                Mark Harding @markeharding · 2 months ago
                Owner

                Screen_Shot_2019-07-09_at_10.19.00_PM

                all is not being set on the API. The button may be saving but you need to toggle on/off to get the list component to realise.

              • Mark Harding @markeharding added MR::Requires Changes scoped label 2 months ago

                added MR::Requires Changes scoped label

              • Ben Hayward @benhayward.ben added 1 commit 2 months ago

                added 1 commit

                • 1b0e9eec - update for feedback

                Compare with previous version

              • Ben Hayward
                Ben Hayward @benhayward.ben · 2 months ago
                Developer

                Okay, I see what you mean. added that in.

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 2 months ago
                Resolved by Ben Hayward 2 months ago
              • Ben Hayward @benhayward.ben added 1 commit 2 months ago

                added 1 commit

                • 04c502a3 - Emit event on load to set querystring properly

                Compare with previous version

              • Ben Hayward @benhayward.ben resolved all threads 2 months ago

                resolved all threads

              • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 2 months ago

                added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

              • Mark Harding @markeharding added Squad::Green scoped label 2 months ago

                added Squad::Green scoped label

              • Ben Hayward @benhayward.ben added 217 commits 2 weeks ago

                added 217 commits

                • 04c502a3...d69d2bd0 - 216 commits from branch master
                • 92f471ca - Merge branch 'master' of gitlab.com:minds/front into fix/default-preferred-state-1366

                Compare with previous version

              • Ben Hayward @benhayward.ben changed title from [Sprint/InterestingIguana] Preferred hashtag remembered in local storage #1366 (closed) to [Sprint/InterestingIguana](feat): Preferred hashtag remembered in local storage #1366 (closed) 2 weeks ago

                changed title from [Sprint/InterestingIguana] Preferred hashtag remembered in local storage #1366 (closed) to [Sprint/InterestingIguana](feat): Preferred hashtag remembered in local storage #1366 (closed)

              • Ben Hayward @benhayward.ben changed the description 2 weeks ago

                changed the description

              • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

                added 1 commit

                • 33831f05 - Linted

                Compare with previous version

              • Ben Hayward @benhayward.ben added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 hour ago

                added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

              • Ben Hayward
                Ben Hayward @benhayward.ben · 1 hour ago
                Developer

                Not working correctly.

                Steps to reproduce faulty behaviour:

                1. Turn off preferred in discovery. (This saves the cookie to the off state).
                2. Click over to another page (do not reload)
                3. Go back to discovery - preferred will be switched on when it should not be.
              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Requires Changes Squad::Green
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              6
              6 participants
              user avatar
              Martin Santangelo
              user avatar
              Brian Hatchet
              user avatar
              Emiliano Balbuena
              user avatar
              Marcelo Rivera
              user avatar
              Mark Harding
              user avatar
              Ben Hayward
              Reference: minds/front!433