Next

Depends on engine#578 (closed) Closes mobile-native#1093 (moved)

Need to add tests before im happy.

mentioned in merge request engine!279

added 1 commit

• 9ddbd7fe - fixed tests

Compare with previous version

changed the description

changed the description

added 1 commit

• a4717b76 - added tests for new component

Compare with previous version

added 1 commit

• 149294c3 - added test

Compare with previous version

added 1 commit

• 32bff9c5 - theming

Compare with previous version

Looking good. Beware of modal -> modal flow though, I think it will replace it and close the previous one down (so not going back).

Also, please don't push up fit.. we should open a ticket to put something in the CI to warn us.

added MR::Requires Changes Squad::Green scoped labels

Crap! Sorry about that. Made a ticket for it here minds#694 (closed)

I'll have a think about it. I had a google and found a few hooks we could maybe use / adapt

• http://niffic.se/2019/05/git-hook-to-stop-committing-focused-tests/
• https://gist.github.com/DerLobi/d938ac7dc422145f85e6

added 1 commit

• 56321036 - Updated to meet feedback (please squash)

Compare with previous version

resolved all threads

added 1 commit

• bc487db6 - Grabbed plus user from config

Compare with previous version

added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

Awaiting feedback to continue and make responsive.

Somewhat of a discrepancy from my local and this here pipeline. The engine seems to be functioning correctly, because the new config endpoint served value for plus_guid is available on the site at Minds.blockchain.plus_guid. (can the sandbox using web dev tools).

The front-end here, in contrast to my local does not working at all, as the modal doesn't pop-up.

minds-plus-tiers

unmarked as a Work In Progress

marked as a Work In Progress

added 1 commit

• 4f5ce1d6 - minor

Compare with previous version

added 1 commit

• f611744c - test console

Compare with previous version

approved this merge request

Tested and works great.

@ottman found an issue with responsiveness and the button

Just need to make it not WIP. I will create a card for setting up a pre-git check for removing fits and fdescribes

unapproved this merge request

Yep, don't worry, was not going to add that in following feedback, as the whole design could have changed.

added 2 commits

• eb8c3456 - update to meet feedback
• ed814110 - Merge branch 'feat/plus-tiers-578' of gitlab.com:minds/front into feat/plus-tiers-578

Compare with previous version

added 2 commits

• 15472022 - fixed up metamask
• 727ebfcc - more updates

Compare with previous version

added 1 commit

• ab6a5129 - adding tests

Compare with previous version

added 1 commit

• cde37326 - formatting

Compare with previous version

added 1 commit

• 8e10a733 - removing unneeded change to file

Compare with previous version

added 1 commit

• 20cd27a7 - Randomly failing test.

Compare with previous version

added 1 commit

• af03f3b3 - failed build

Compare with previous version

More feedback from @jotto141

Jack doesnt really seem different than the last one still says "Upgrade - 20 tokens / month" on the plus page. Should just say "Purchase" or "Upgrade" Jack and I still see all of the USD options, need to hide those til we have Stripe working with it and not sure if purchasing should be working yet or not, just getting errors when i try

Just a reminder, we still need an answer to what we do about the token limit. Do we make an exception for plus, or raise it?

added 1 commit

• a7e02de0 - aethetic changes

Compare with previous version

added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

Updated anyway to meet that feedback - not going to put the values in helm yet as we still need to work out how to handle lifetime without going over the max daily token limit.

@jotto141 @markeharding @ottman this one still stuck in limbo until I hear back re: the pricing.