Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 842
    • Issues 842
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 43
    • Merge Requests 43
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !550

Open
Opened 3 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/NuancedNumbat](fix): Do not show post if deleted.

Closes #1732

I believe this to be the correct way to take care of it, as the remaining line after deletion caused by border offers an indicator of where the post was. Can be taken care of if anybody disagree's - easy enough to add conditional css but I left it in because it felt better to me.

It appears that the _deleted event emitter is not implemented properly, but I don't feel deferring 'deletion' to the parent is the correct solution anyway.

Note in the HTML file, all I have done is wrapped it in an ng-container conditionally tied to whether the post is in a deleted or not. The large amount of changes come from adjusting the indentation.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "fix/activity-deletion-detection-1732" "origin/fix/activity-deletion-detection-1732"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "fix/activity-deletion-detection-1732"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/activity-deletion-detection-1732 into master
The source branch is 14 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #81822895 failed for a3316300 on fix/activity-deletion-detection-1732
              Requires 2 more approvals from Devs and Deployers.
              Brian Hatchet
              Brian Hatchet
              Olivia Madrid
              Olivia Madrid
              Emiliano Balbuena
              Emiliano Balbuena
              Martin Santangelo
              Martin Santangelo
              Guy Thouret
              Guy Thouret
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1732

              Deletes source branch

              • Discussion 1
              • Commits 1
              • Pipelines 1
              • Changes 2
              • Loading...
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 3 days ago

                added MR::Awaiting Review Squad::Yellow scoped labels

              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 hour ago

                added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

              • Mark Harding
                Mark Harding @markeharding · 1 hour ago
                Owner

                Failing at build step here

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Requires Changes Squad::Yellow
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Brian Hatchet
              user avatar
              Olivia Madrid
              user avatar
              Emiliano Balbuena
              user avatar
              Martin Santangelo
              user avatar
              Guy Thouret
              user avatar
              Mark Harding
              user avatar
              Marcelo Rivera
              Reference: minds/front!550