Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 842
    • Issues 842
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 43
    • Merge Requests 43
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !469

Merged
Opened 1 month ago by Brian Hatchet@brianhatchet:speech_balloon:
  • Report abuse
Report abuse

Fix/comments media gallery 1601

Finally got the cards working. The ultimate culprit was the comment button on the blog, which doesn't even do anything with comments, just opens the blog

Edited 1 month ago by Brian Hatchet
Request to merge fix/comments-media-gallery-1601 into master
  • Email patches
  • Plain diff
Pipeline #82080757 failed for 07982d03 on fix/comments-media-gallery-1601
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Martin Santangelo
              Martin Santangelo
              Ben Hayward
              Ben Hayward
              Marcelo Rivera
              Marcelo Rivera

              Merged by Mark Harding 1 hour ago

              The changes were merged into master with 7c437600

              The source branch has been deleted

              Pipeline #82353135 waiting for manual action for 7c437600 on master
                            • Discussion 2
                            • Commits 31
                            • Pipelines 22
                            • Changes 49
                            • Loading...
                            • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %sprint: Interesting Iguana 1 month ago

                              changed milestone to %sprint: Interesting Iguana

                            • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 month ago

                              added 1 commit

                              • 85e1c3ad - Test console log

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet added 2 commits 1 month ago

                              added 2 commits

                              • 0f8e4a4b - Removing diagnostic comment
                              • baa22ca9 - Adding activity service to whatever component implements activity.html

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet added 8 commits 1 month ago

                              added 8 commits

                              • baa22ca9...7ea9e831 - 7 commits from branch master
                              • 50534f2a - Merge remote-tracking branch 'origin/master' into fix/comments-media-gallery-1601

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet added 19 commits 1 month ago

                              added 19 commits

                              • 50534f2a...d2a4fe13 - 17 commits from branch master
                              • c3e702d7 - Merge remote-tracking branch 'origin/master' into fix/comments-media-gallery-1601
                              • f07edd55 - Testing emi's boost component fix

                              Compare with previous version

                            • Mark Harding
                              Mark Harding @markeharding · 1 month ago
                              Owner

                              @brianhatchet is this WIP?

                            • Brian Hatchet :speech_balloon: @brianhatchet changed title from Fix/comments media gallery 1601 to (WIP) Fix/comments media gallery 1601 1 month ago

                              changed title from Fix/comments media gallery 1601 to (WIP) Fix/comments media gallery 1601

                            • Brian Hatchet :speech_balloon: @brianhatchet added 6 commits 1 month ago

                              added 6 commits

                              • f07edd55...4f14088f - 5 commits from branch master
                              • 43dc7ff6 - Merge remote-tracking branch 'origin/master' into fix/comments-media-gallery-1601

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 month ago

                              added 1 commit

                              • 86ce5627 - Trying skipself

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet added 5 commits 1 month ago

                              added 5 commits

                              • 86ce5627...9c9d23d9 - 4 commits from branch master
                              • edc7bc92 - Merge remote-tracking branch 'origin/master' into fix/comments-media-gallery-1601

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 1 month ago

                              added 1 commit

                              • dd16f684 - (fix): Inject on featured-content component

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 1 month ago

                              added 1 commit

                              • 676c6f3a - (fix): Provide activity service on blog cards

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet changed title from (WIP) Fix/comments media gallery 1601 to Fix/comments media gallery 1601 1 month ago

                              changed title from (WIP) Fix/comments media gallery 1601 to Fix/comments media gallery 1601

                            • Brian Hatchet :speech_balloon: @brianhatchet changed the description 1 month ago

                              changed the description

                            • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %"sprint: Kilted Koala" 1 month ago

                              changed milestone to %"sprint: Kilted Koala"

                            • Emiliano Balbuena @edgebal approved this merge request 1 month ago

                              approved this merge request

                            • Brian Hatchet :speech_balloon: @brianhatchet added 5 commits 1 month ago

                              added 5 commits

                              • 676c6f3a...6d942fb6 - 4 commits from branch master
                              • b1b680b5 - Merge branch 'master' into fix/comments-media-gallery-1601

                              Compare with previous version

                            • Mark Harding
                              Mark Harding @markeharding · 1 week ago
                              Owner

                              @brianhatchet can you sync up master?

                            • Brian Hatchet :speech_balloon: @brianhatchet added 87 commits 1 week ago

                              added 87 commits

                              • b1b680b5...100602ee - 84 commits from branch master
                              • 4091c065 - Prettier-ed
                              • 9c492adb - Prettier-ed
                              • 4f00b18e - Prettier'ed, updated

                              Compare with previous version

                              Toggle commit list
                            • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 week ago

                              added 1 commit

                              • 6f286102 - relinted

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet added 4 commits 1 week ago

                              added 4 commits

                              • 6f286102...e6c32aca - 2 commits from branch master
                              • 83b8d6ac - Merge remote-tracking branch 'origin/master' into fix/comments-media-gallery-1601
                              • 59957317 - Had to mock the feature flag service and get the feature flag turned on for...

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 week ago

                              added 1 commit

                              • 0368745e - delinted

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 week ago

                              added 1 commit

                              • fa22f9df - Fixed a merge format break on an html template

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet added 15 commits 1 week ago

                              added 15 commits

                              • fa22f9df...950f589d - 14 commits from branch master
                              • d049cd58 - Merge remote-tracking branch 'origin/master' into fix/comments-media-gallery-1601

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet added 3 commits 6 days ago

                              added 3 commits

                              • d049cd58...2be70043 - 2 commits from branch master
                              • 33bf36d4 - Merge remote-tracking branch 'origin/master' into fix/comments-media-gallery-1601

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 6 days ago

                              added 1 commit

                              • f4d5b492 - Fixing lint

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet added 12 commits 5 days ago

                              added 12 commits

                              • f4d5b492...c73d763e - 8 commits from branch master
                              • 863b64f4 - refactoring for more comments tests
                              • c09195d1 - Merge remote-tracking branch 'origin/master' into fix/comments-media-gallery-1601
                              • 29cce9f3 - Merge remote-tracking branch 'origin/master' into fix/comments-media-gallery-1601
                              • e2731ec0 - channel and image end to end tests to make sure the comment buttons load

                              Compare with previous version

                              Toggle commit list
                            • Emiliano Balbuena @edgebal approved this merge request 3 days ago

                              approved this merge request

                            • Brian Hatchet :speech_balloon: @brianhatchet added 14 commits 2 days ago

                              added 14 commits

                              • e2731ec0...f93cf103 - 13 commits from branch master
                              • c386ffe5 - Merge remote-tracking branch 'origin/master' into fix/comments-media-gallery-1601

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet added 7 commits 2 days ago

                              added 7 commits

                              • c386ffe5...a2344c91 - 6 commits from branch master
                              • 07982d03 - Merge remote-tracking branch 'origin/master' into fix/comments-media-gallery-1601

                              Compare with previous version

                            • Mark Harding @markeharding approved this merge request 1 hour ago

                              approved this merge request

                            • Mark Harding @markeharding mentioned in commit 7c437600 1 hour ago

                              mentioned in commit 7c437600

                            • Mark Harding @markeharding merged 1 hour ago

                              merged

                            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                            Please register or sign in to reply
                            Assignee
                            Brian Hatchet's avatar
                            Brian Hatchet @brianhatchet
                            Assign to
                            (07/31) Kilted Koala
                            Milestone
                            (07/31) Kilted Koala
                            Assign milestone
                            None
                            Time tracking
                            No estimate or time spent
                            0
                            Labels
                            None
                            Assign labels
                            • View project labels
                            Lock merge request
                            Unlocked
                            6
                            6 participants
                            user avatar
                            Emiliano Balbuena
                            user avatar
                            Martin Santangelo
                            user avatar
                            Ben Hayward
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Brian Hatchet
                            user avatar
                            Mark Harding
                            Reference: minds/front!469

                            Revert this merge request

                            This will create a new commit in order to revert the existing changes.

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.

                            Cherry-pick this merge request

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.