Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 845
    • Issues 845
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 46
    • Merge Requests 46
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !483

Open
Opened 1 month ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/KiltedKoala](feat): Added e2e test for registration

Closes #1638 (closed)

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "feat/registration-e2e-1638" "origin/feat/registration-e2e-1638"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "feat/registration-e2e-1638"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/registration-e2e-1638 into master
The source branch is 21 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #82022599 passed with warnings for e3b7e2a9 on feat/registration-e2e-1638
              Requires 2 more approvals from Devs and Deployers.
              Juan Manuel Solaro
              Juan Manuel Solaro
              Guy Thouret
              Guy Thouret
              Brian Hatchet
              Brian Hatchet
              Emiliano Balbuena
              Emiliano Balbuena
              Martin Santangelo
              Martin Santangelo
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1638 (closed)

              Deletes source branch

              • Discussion 4
              • Commits 5
              • Pipelines 4
              • Changes 2
              2/3 threads resolved
              • Loading...
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Green scoped labels 1 month ago

                added MR::Awaiting Review Squad::Green scoped labels

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 month ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet added 9 commits 1 month ago

                added 9 commits

                • 1b662ff0...6d942fb6 - 8 commits from branch master
                • 39ba0928 - Merge branch 'master' into feat/registration-e2e-1638

                Compare with previous version

              • Ben Hayward @benhayward.ben added 105 commits 3 days ago

                added 105 commits

                • 39ba0928...2be70043 - 102 commits from branch master
                • 81a263c1 - Updated registration tests
                • 516f7281 - Merge branch 'master' of gitlab.com:minds/front into feat/registration-e2e-1638
                • bbd3d77a - Fixed up registration test

                Compare with previous version

                Toggle commit list
              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 days ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet unapproved this merge request 2 days ago

                unapproved this merge request

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet started a thread on an old version of the diff 2 days ago
                Last updated by Ben Hayward 1 hour ago
                cypress/integration/registration.spec.js
                38 //type values
                39 cy.get(usernameField).focus().type(username);
                40 cy.get(emailField).focus().type(email);
                41 cy.get(passwordField).focus().type(password);
                42
                43 cy.get(password2Field).focus().type(password);
                44 cy.get(checkbox).click();
                45
                46 //submit
                47 cy.get(submitButton).click()
                48 .wait('@register').then((xhr) => {
                49 expect(xhr.status).to.equal(200);
                50 });
                51
                52 //onboarding modal shown
                53 cy.get('m-onboarding--topics > div > h2:nth-child(1)')
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 2 days ago
                  Developer

                  Let's stop using these nth child selectors

                • Ben Hayward @benhayward.ben changed this line in version 4 of the diff 1 hour ago

                  changed this line in version 4 of the diff

                • Ben Hayward
                  Ben Hayward @benhayward.ben · 1 hour ago
                  Developer

                  Funnily enough, literally getting rid of the get call here achieves that, because the call to contains is all thats needed to find the text in the DOM.

                • Please register or sign in to reply
              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet started a thread on an old version of the diff 2 days ago
                Resolved by Ben Hayward 1 hour ago
              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet started a thread on an old version of the diff 2 days ago
                Resolved by Ben Hayward 1 hour ago
              • Ben Hayward @benhayward.ben added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 2 days ago

                added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

              • Ben Hayward @benhayward.ben added 1 commit 1 hour ago

                added 1 commit

                • e3b7e2a9 - Added data attributes.

                Compare with previous version

              • Ben Hayward @benhayward.ben resolved all threads 1 hour ago

                resolved all threads

              • Ben Hayward @benhayward.ben added Squad::Yellow scoped label and automatically removed Squad::Green label 1 hour ago

                added Squad::Yellow scoped label and automatically removed Squad::Green label

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Requires Changes Squad::Yellow
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Juan Manuel Solaro
              user avatar
              Guy Thouret
              user avatar
              Brian Hatchet
              user avatar
              Emiliano Balbuena
              user avatar
              Martin Santangelo
              user avatar
              Marcelo Rivera
              user avatar
              Olivia Madrid
              Reference: minds/front!483